-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move clone_progress to separate list #2929
Conversation
32a02e8
to
25ca444
Compare
Since clone_progress metric used for internal purpose only we should not document it in metrics.md or test it in the metrics linter. therefore clone_progress moved to separate list (not used by the doc and linter generators). Signed-off-by: Aviv Litman <[email protected]>
25ca444
to
ab4de1f
Compare
/retest |
Please do not merge this PR before @sradco approves. |
/hold waiting on @sradco to review |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Since clone_progress metric used for internal purpose only we should not document it in metrics.md or test it in the metrics linter. therefore clone_progress moved to separate list (not used by the doc and linter generators).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2515
Jira-ticket: https://issues.redhat.com/browse/CNV-33647
Special notes for your reviewer:
This fix was discussed with CDI developer.
Release note: