-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Portworx CSI storage capabilities #2789
Conversation
@@ -89,7 +89,7 @@ var CapabilitiesByProvisionerKey = map[string][]StorageCapabilities{ | |||
"pxd.openstorage.org/shared": createOpenStorageSharedVolumeCapabilities(), | |||
"pxd.openstorage.org": createRWOBlockAndFilesystemCapabilities(), | |||
"pxd.portworx.com/shared": createOpenStorageSharedVolumeCapabilities(), | |||
"pxd.portworx.com": createRWOBlockAndFilesystemCapabilities(), | |||
"pxd.portworx.com": {{rwx, file}, {rwo, block}, {rwo, file}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this can be static? no dependency on shared=true?
https://docs.portworx.com/operations/operate-kubernetes/storage-operations/kubernetes-storage-101/volumes/#readwritemany-and-readwriteonce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orenc1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for shared: true
in the storage class parameters for it to be ReadWriteMany, as far as I saw.
I used a PVC of Filesystem ReadWriteMany with px-csi-db
SC.
@@ -89,7 +89,7 @@ var CapabilitiesByProvisionerKey = map[string][]StorageCapabilities{ | |||
"pxd.openstorage.org/shared": createOpenStorageSharedVolumeCapabilities(), | |||
"pxd.openstorage.org": createRWOBlockAndFilesystemCapabilities(), | |||
"pxd.portworx.com/shared": createOpenStorageSharedVolumeCapabilities(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that we are saying RWX/Block is supported but https://github.com/libopenstorage/openstorage/blob/master/csi/controller.go#L408-L412 begs to differ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we may need to revamp and correct the portworx caps and backport to previous releases too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so the code impliciltly says RWX/File,RWO/Block,RWO/File are supported in the shared provisioners?
/test pull-containerized-data-importer-e2e-upg |
Signed-off-by: Arnon Gilboa <[email protected]>
ddc55f5
to
e5ba88e
Compare
"pxd.portworx.com/shared": createOpenStorageSharedVolumeCapabilities(), | ||
"pxd.portworx.com": createRWOBlockAndFilesystemCapabilities(), | ||
"pxd.portworx.com": createOpenStorageSharedVolumeCapabilities(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created DVs on pxd.portworx.com
- all these Succeeded: {RWX, FS}, {RWO, Block}, {RWO, FS}
@jpeimer: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey! We are trying to provide some defaults for Portworx storage classes containerized-data-importer/pkg/storagecapabilities/storagecapabilities.go Lines 298 to 304 in e5ba88e
Also IIUC "shared" is deprecated, and our code still filters based on that containerized-data-importer/pkg/storagecapabilities/storagecapabilities.go Lines 234 to 240 in e5ba88e
|
@akalenyu: GitHub didn't allow me to request PR reviews from the following users: luayalem, pureneelesh. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Following offline discussion, we will pursue pinpointed portworx variation filtering outside of this PR. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/test pull-containerized-data-importer-e2e-upg |
/cherrypick release-v1.57 |
@akalenyu: new pull request created: #2890 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-v1.56 |
@arnongilboa: #2789 failed to apply on top of branch "release-v1.56":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual backport of kubevirt#2789 Signed-off-by: Arnon Gilboa <[email protected]>
Manual backport of kubevirt#2789, plus minor alignments with main branch. Signed-off-by: Arnon Gilboa <[email protected]>
Manual backport of #2789, plus minor alignments with main branch. Signed-off-by: Arnon Gilboa <[email protected]>
Manual backport of kubevirt#2789, plus minor alignments with main branch. Signed-off-by: Arnon Gilboa <[email protected]>
Manual backport of #2789, plus minor alignments with main branch. Signed-off-by: Arnon Gilboa <[email protected]>
What this PR does / why we need it:
Add preferred
ReadWriteMany, Filesystem
capability to thepxd.portworx.com
provisioner.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
Release note: