Bump ovs-cni to 0.8.0 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
|
@qinqon don't forget to update |
|
The marker also fails with: |
|
We gotta update the manifest, it has been changed on ovs-cni in k8snetworkplumbingwg/ovs-cni#80. |
qinqon
force-pushed
the
ovs-cni_0.8.0
branch
from
176b3ed to
ec1d76d
Compare
|
deploying and activaing OVS works fine. We have to install ovs at nodes, why we didn't need it before ? the socket was created by container if does not exists ? |
qinqon
force-pushed
the
ovs-cni_0.8.0
branch
from
ec1d76d to
e09767b
Compare
qinqon
force-pushed
the
ovs-cni_0.8.0
branch
3 times, most recently
from
1103511 to
8f8e702
Compare
|
That's what I commented. The difference is in the format of the socket parameter. |
|
Also the path, /run/openvswitch is no good. Now it has all it needs also I think we no longer need localbin since we are not using ovs-vsctl |
phoracek
requested changes
Nov 29, 2019
| @@ -135,9 +135,7 @@ systemctl start NetworkManager | |||
| ## Open vSwitch | |||
|
|
|||
| The operator allows administrator to deploy [OVS CNI plugin](https://github.com/kubevirt/ovs-cni/) | |||
| simply by adding `ovs` attribute to `NetworkAddonsConfig`. Please note that | |||
There was a problem hiding this comment.
Please say that openvswitch has to be running on the node.
To include the bridge reporting fix [1] [1] k8snetworkplumbingwg/ovs-cni#93 Signed-off-by: Quique Llorente <[email protected]>
qinqon
force-pushed
the
ovs-cni_0.8.0
branch
from
8f8e702 to
0d6a24e
Compare
phoracek
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To include the bridge reporting fix [1]
[1] k8snetworkplumbingwg/ovs-cni#93
Signed-off-by: Quique Llorente [email protected]