Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Bump k8s to 0.31.0 #1964

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Jan 2, 2025

What this PR does / why we need it:
This PR bumps vendors of k8s to 0.31.0.
Other significant bumps that were needed:

  • controller-runtime to v0.19.3
  • kubevirt to v1.4.0
  • prometheus-operator to v0.68.0

Updated relevant functions accordingly accordingly.

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 2, 2025
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 2, 2025

/hold

still need to fix predicates

@kubevirt-bot kubevirt-bot added size/XXL do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 2, 2025
@RamLavi RamLavi force-pushed the vendor_bump_k8s_0.31.0 branch from ce9b6e6 to 9148625 Compare January 5, 2025 07:54
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 5, 2025

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2025
@RamLavi RamLavi force-pushed the vendor_bump_k8s_0.31.0 branch from a138782 to ee1ed78 Compare January 6, 2025 08:24
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 6, 2025

/hold

/retest
I vaguely remember this flaky, but I want to be sure

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2025
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 6, 2025

/test pull-e2e-cluster-network-addons-operator-workflow-k8s
/test pull-e2e-cluster-network-addons-operator-lifecycle-k8s

1 similar comment
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 6, 2025

/test pull-e2e-cluster-network-addons-operator-workflow-k8s
/test pull-e2e-cluster-network-addons-operator-lifecycle-k8s

@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 6, 2025

/test pull-e2e-cluster-network-addons-operator-workflow-k8s
/test pull-e2e-cluster-network-addons-operator-lifecycle-k8s

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2025
@RamLavi RamLavi force-pushed the vendor_bump_k8s_0.31.0 branch 2 times, most recently from dd3b9b2 to aecad8b Compare January 7, 2025 13:35
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 7, 2025

/hold
until rebased on top of #1971

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 7, 2025
Bump to latest kubevirtci tag
Refactor cluster::install(), replacing single bracket "-o" syntax.

Signed-off-by: Ram Lavi <[email protected]>
Other significant bumps that were needed:
- controller-runtime to v0.19.3
- kubevirt to v1.4.0
- prometheus-operator to v0.68.0

Updated relevant functions accordingly accordingly.

Signed-off-by: Ram Lavi <[email protected]>
@RamLavi RamLavi force-pushed the vendor_bump_k8s_0.31.0 branch from aecad8b to 6c8d1c3 Compare January 8, 2025 09:00
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2025
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 8, 2025

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@qinqon
Copy link
Collaborator

qinqon commented Jan 9, 2025

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@kubevirt-bot kubevirt-bot merged commit 3ef8e67 into kubevirt:main Jan 9, 2025
15 checks passed
RamLavi added a commit to RamLavi/cluster-network-addons-operator that referenced this pull request Jan 9, 2025
* cluster: Bump kubevirtci tag, refactor install function

Bump to latest kubevirtci tag
Refactor cluster::install(), replacing single bracket "-o" syntax.

Signed-off-by: Ram Lavi <[email protected]>

* vendor: Bump k8s to 0.31.0

Other significant bumps that were needed:
- controller-runtime to v0.19.3
- kubevirt to v1.4.0
- prometheus-operator to v0.68.0

Updated relevant functions accordingly accordingly.

Signed-off-by: Ram Lavi <[email protected]>

---------

Signed-off-by: Ram Lavi <[email protected]>
kubevirt-bot pushed a commit that referenced this pull request Jan 9, 2025
* cluster: Bump kubevirtci tag, refactor install function

Bump to latest kubevirtci tag
Refactor cluster::install(), replacing single bracket "-o" syntax.



* vendor: Bump k8s to 0.31.0

Other significant bumps that were needed:
- controller-runtime to v0.19.3
- kubevirt to v1.4.0
- prometheus-operator to v0.68.0

Updated relevant functions accordingly accordingly.



---------

Signed-off-by: Ram Lavi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants