kubevirtci: Bump version #1807
kubevirtci: Bump version #1807
Conversation
kubevirt-bot
added
dco-signoff: yes
|
|
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1807/pull-e2e-cluster-network-addons-operator-ovs-cni-functests/1799769689681825792 Those are failing, rerunning just to see if it is flake or static /retest |
|
closing this need to be fixed on a follow-up orthogonal effort note - one of them happens also on clean main |
kubevirt-bot
added
the
do-not-merge/work-in-progress
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
@phoracek |
| @@ -18,7 +18,7 @@ versionChanged() { | |||
| } | |||
|
|
|||
| main() { | |||
| export KUBEVIRT_PROVIDER='k8s-1.25' | |||
| export KUBEVIRT_PROVIDER='k8s-1.28' | |||
There was a problem hiding this comment.
we can even drop this line (and the one in the next 2 files)
as it is the default anyhow taken from cluster.sh
kubevirt-bot
added
the
do-not-merge/hold
kubevirt-bot
added
the
do-not-merge/work-in-progress
|
/test pull-e2e-cluster-network-addons-operator-kubemacpool-functests |
|
/test pull-e2e-cluster-network-addons-operator-kubemacpool-functests |
|
passed /test pull-e2e-cluster-network-addons-operator-kubemacpool-functests edit passed twice |
| @@ -20,6 +20,10 @@ main() { | |||
| source automation/check-patch.setup.sh | |||
| cd ${TMP_PROJECT_PATH} | |||
|
|
|||
| # until we fix OVS lane on the newer kubevirtci | |||
There was a problem hiding this comment.
Mark this with TODO and link the tracker of the issue
There was a problem hiding this comment.
found the root cause it seems, will try to fix it from the root
here it passed as poc
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1807/pull-e2e-cluster-network-addons-operator-ovs-cni-functests/1808451984412381184
There was a problem hiding this comment.
dropped since the root cause is fixed
| @@ -18,7 +18,7 @@ versionChanged() { | |||
| } | |||
|
|
|||
| main() { | |||
| export KUBEVIRT_PROVIDER='k8s-1.25' | |||
| export KUBEVIRT_PROVIDER='k8s-1.28' | |||
| @@ -99,6 +99,15 @@ git-utils::fetch_component ${component_path} ${component_url} ${component_commit | |||
|
|
|||
| export TMP_COMPONENT_PATH=${component_path} | |||
|
|
|||
| # TODO remove | |||
There was a problem hiding this comment.
Either remove this or provide enough context to make this actionable
There was a problem hiding this comment.
gonna be dropped before this PR is merged
just used for poc
There was a problem hiding this comment.
removed, lets see all pass (required PRs were merged on OVS/KMP)
| @@ -99,6 +99,15 @@ git-utils::fetch_component ${component_path} ${component_url} ${component_commit | |||
|
|
|||
| export TMP_COMPONENT_PATH=${component_path} | |||
|
|
|||
| # TODO remove | |||
| if [[ COMPONENT=="kubemacpool" ]]; then | |||
There was a problem hiding this comment.
| if [[ COMPONENT=="kubemacpool" ]]; then | |
| if [[ $COMPONENT == "kubemacpool" ]]; then |
IIUIC the statement you used would always return true
There was a problem hiding this comment.
the PR is WIP / draft as i debug something all those will be dropped
not ready to review (saw the failure just after i asked sorry)
thanks
There was a problem hiding this comment.
right, was fixed later thanks,
but anyhow it will be dropped before this PR is merged, just poced to see it fix the root problem
(dropped)
|
hold would be removed once the last commit is dropped, atm it is there just to see the fixes it poced |
oshoval
force-pushed
the
bumpkci
branch
3 times, most recently
from
84fe039
to
95c949a
Compare
Also allow to override KUBEVIRTCI_TAG. Signed-off-by: Or Shoval <[email protected]>
The default value at cluster.sh already has the right value. One source of truth is much better. Signed-off-by: Or Shoval <[email protected]>
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
|
comments were addressed, all debug code was remove, and at the end we don't need to pin OVS This change was done for KMP and OVS, and should be done for the rest of the repos, but it doesnt block this PR |
|
all passed, addressed comments, /lgtm |
|
@oshoval: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
This reverts commit 8f67002.
This reverts commit 8f67002.
This reverts commit 8f67002.
This reverts commit 8f67002.
This reverts commit 8f67002.
What this PR does / why we need it:
Bump kubevirtci and cleanup unrequired exports.
Allow pinning specific kubevirtci per lane.
It will allow decoupling kubevirtci tag version between the lanes.
Special notes for your reviewer:
Release note: