Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove acr image #844

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Jun 20, 2023

Description of your changes

Depracate acr, improve code readability.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (c50db15) 60.94% compared to head (a6a5acd) 60.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
- Coverage   60.94%   60.87%   -0.07%     
==========================================
  Files         110      110              
  Lines       19406    19409       +3     
==========================================
- Hits        11827    11816      -11     
- Misses       6118     6128      +10     
- Partials     1461     1465       +4     
Flag Coverage Δ
apiserver-unittests 33.86% <100.00%> (-0.09%) ⬇️
server-e2e-tests 49.14% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/plugin/types/plugin.go 40.00% <ø> (ø)
pkg/plugin/router/router.go 90.00% <100.00%> (+1.11%) ⬆️
pkg/server/server.go 54.54% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Qiaozp <[email protected]>
@chivalryq chivalryq merged commit 7a81518 into kubevela:main Jun 21, 2023
@chivalryq chivalryq deleted the chore/remove-acr branch June 21, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants