Feat: add MySQL data store driver implementation #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeerajGartia21
requested review from
barnettZQG,
chivalryq,
wangyikewxgm,
yangsoon and
FogDong
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
==========================================
- Coverage 60.46% 59.00% -1.47%
==========================================
Files 113 114 +1
Lines 19607 19818 +211
==========================================
- Hits 11856 11694 -162
- Misses 6299 6687 +388
+ Partials 1452 1437 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
NeerajGartia21
force-pushed
the
mysql-driver
branch
from
f9805c0
to
fe3ade9
Compare
chivalryq
reviewed
Jun 12, 2023
|
Sure! I will add the implementation of the MySql driver methods ASAP. |
NeerajGartia21
force-pushed
the
mysql-driver
branch
from
161ff9b
to
1957c47
Compare
chivalryq
reviewed
Jun 16, 2023
|
|
||
| func TestMySQL(t *testing.T) { | ||
| _, err := New(context.TODO(), datastore.Config{ | ||
| URL: "root:kubevelaSQL123@tcp(127.0.0.1:3306)/kubevela?parseTime=True", |
There was a problem hiding this comment.
It would be better we add the format explaination in our document. Or in helm chart.
There was a problem hiding this comment.
Format explanation for the Database URL right?
There was a problem hiding this comment.
I think, it can be added while adding documentation for mysql driver.
chivalryq
changed the title
NeerajGartia21
force-pushed
the
mysql-driver
branch
4 times, most recently
from
2cebb92
to
bf81ad5
Compare
chivalryq
reviewed
Jun 25, 2023
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
NeerajGartia21
force-pushed
the
mysql-driver
branch
from
be6efcb
to
eb6ce52
Compare
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
|
Thanks @chivalryq !! |
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer