-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add MySQL database driver #825
Conversation
Signed-off-by: Neeraj Gartia <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
==========================================
- Coverage 61.13% 61.09% -0.04%
==========================================
Files 109 110 +1
Lines 19143 19174 +31
==========================================
+ Hits 11703 11715 +12
- Misses 5989 6011 +22
+ Partials 1451 1448 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
Please fix the static check CI and rebase after this is merged: #826 |
Signed-off-by: Neeraj Gartia <[email protected]>
Done @chivalryq ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of your changes
This PR adds MySQL driver for the VelaUX api-server
Fixes #
I have:
yarn lint
to ensure the frontend changes are ready for review.make reviewable
to ensure the server changes are ready for review.backport release-x.y
labels to auto-backport this PR if necessary.Special notes for your reviewer