Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: adds steps for installing kubebuilder and its dependency tools to makefile #821

Merged
merged 1 commit into from
May 18, 2023

Conversation

NeerajGartia21
Copy link
Collaborator

Description of your changes

This PR adds make setup-test-server command to makefile for installing kubebuilder and its dependency tools to .
Also contribution docs is modified accordingly.

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (04715c7) 61.22% compared to head (9933a1a) 61.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   61.22%   61.15%   -0.08%     
==========================================
  Files         109      109              
  Lines       19143    19143              
==========================================
- Hits        11721    11706      -15     
- Misses       5976     5988      +12     
- Partials     1446     1449       +3     
Flag Coverage Δ
apiserver-unittests 33.75% <ø> (+0.06%) ⬆️
server-e2e-tests 49.80% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit c55b911 into kubevela:main May 18, 2023
@NeerajGartia21 NeerajGartia21 deleted the kubebuilder-setup branch June 9, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants