-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: prevent caching js when http code isn't 200 #814
Conversation
Signed-off-by: Qiaozp <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
==========================================
- Coverage 61.13% 61.10% -0.03%
==========================================
Files 109 109
Lines 19134 19143 +9
==========================================
Hits 11697 11697
- Misses 5988 5992 +4
- Partials 1449 1454 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Qiaozp <[email protected]>
Signed-off-by: Qiaozp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Successfully created backport PR #816 for |
Description of your changes
Ref #811
This PR prevent caching non-200 http response in JsCache. Add some logs to track the issue better.
Fixes #
I have:
yarn lint
to ensure the frontend changes are ready for review.make reviewable
to ensure the server changes are ready for review.backport release-x.y
labels to auto-backport this PR if necessary.Special notes for your reviewer