Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: upgrade k8s.io to 0.26 and kubevela to 1.9.0 #783

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

nuclearwu
Copy link
Contributor

@nuclearwu nuclearwu commented Apr 20, 2023

Signed-off-by: wuzhongjian [email protected]

Description of your changes

Fixes kubevela/kubevela#5088

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.28 ⚠️

Comparison is base (eca8d1d) 61.38% compared to head (7232b7b) 61.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   61.38%   61.11%   -0.28%     
==========================================
  Files         109      109              
  Lines       19138    19141       +3     
==========================================
- Hits        11748    11698      -50     
- Misses       5954     5994      +40     
- Partials     1436     1449      +13     
Flag Coverage Δ
apiserver-unittests 33.73% <14.28%> (-0.03%) ⬇️
server-e2e-tests 49.74% <57.14%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/event/sync/worker.go 74.64% <25.00%> (-3.30%) ⬇️
pkg/server/utils/auth.go 67.24% <100.00%> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nuclearwu
Copy link
Contributor Author

@wonderflow @barnettZQG @FogDong @Somefive please review

Copy link
Contributor

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit b0c407f into kubevela:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]helm repository and image registry support authenticate registry with credential specified
4 participants