Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add plugin enable/disable sub-page #764

Merged
merged 29 commits into from
Jun 1, 2023

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Apr 13, 2023

Description of your changes

Addon page

image

plugin page

image

Plugin config page

image

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@chivalryq chivalryq changed the title Add plugin enable/disable sub-page Feat: add plugin enable/disable sub-page Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 41.89% and project coverage change: +27.19 🎉

Comparison is base (92d097c) 33.77% compared to head (263ca6c) 60.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #764       +/-   ##
===========================================
+ Coverage   33.77%   60.97%   +27.19%     
===========================================
  Files          89      109       +20     
  Lines       17656    19309     +1653     
===========================================
+ Hits         5964    11774     +5810     
+ Misses      10801     6080     -4721     
- Partials      891     1455      +564     
Flag Coverage Δ
apiserver-unittests 33.73% <32.96%> (-0.05%) ⬇️
server-e2e-tests 49.44% <12.84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/plugin/loader/loader.go 45.39% <ø> (ø)
pkg/server/interfaces/api/dto/v1/types.go 73.33% <ø> (ø)
pkg/server/interfaces/api/plugin.go 53.40% <39.02%> (+50.75%) ⬆️
pkg/server/domain/service/plugin.go 57.59% <42.75%> (-5.64%) ⬇️

... and 92 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chivalryq chivalryq force-pushed the feat/plugin-page branch 2 times, most recently from 40d31db to bc75135 Compare April 17, 2023 03:03
@wonderflow wonderflow mentioned this pull request Apr 17, 2023
5 tasks
wonderflow and others added 15 commits April 28, 2023 11:54
Signed-off-by: Jianbo Sun <[email protected]>
install test

add uninstall

export plugin api to @velaux/ui

Signed-off-by: Qiaozp <[email protected]>
Signed-off-by: Qiaozp <[email protected]>
Signed-off-by: Qiaozp <[email protected]>
Signed-off-by: Qiaozp <[email protected]>
Remove icon test
remove checkimage

Signed-off-by: Qiaozp <[email protected]>
Fix test

Signed-off-by: Qiaozp <[email protected]>
@chivalryq
Copy link
Member Author

/retest server-e2e-tests

@chivalryq
Copy link
Member Author

/retest server-test

Signed-off-by: Qiaozp <[email protected]>
Signed-off-by: Qiaozp <[email protected]>
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit d2ecefa into kubevela:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants