Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 'Numbers' ui-type in default ui schema #744

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

basuotian
Copy link
Contributor

Description of your changes

Fixes #659

In vela-core default ui-type, number array will return ui-type Numbers, but velaux didn't implement ui-type Numbers.

case "array":
    if subType == "string" {
	    return "Strings"
    }
    if subType == "number" || subType == "integer" {
	    return "Numbers"
    }
    return "Structs"

The new ui-type preview:

image

Btw, i think the annotations in trait expose is optional, but default validate is required.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (1dec098) 61.08% compared to head (dbab05d) 61.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   61.08%   61.14%   +0.06%     
==========================================
  Files          99       99              
  Lines       18081    18081              
==========================================
+ Hits        11044    11056      +12     
+ Misses       5694     5684      -10     
+ Partials     1343     1341       -2     
Flag Coverage Δ
apiserver-unittests 32.59% <ø> (-0.01%) ⬇️
server-e2e-tests 50.04% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit 9bbb0b9 into kubevela:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] VelaUX can not show the parameters of Trait Expose
2 participants