Feat: support download pod lods in velaux #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Basuotian <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
===========================================
+ Coverage 50.13% 60.62% +10.48%
===========================================
Files 98 98
Lines 17974 17974
===========================================
+ Hits 9012 10897 +1885
+ Misses 7815 5740 -2075
- Partials 1147 1337 +190
Flags with carried forward coverage won't be shown. Click here to find out more. see 37 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
barnettZQG
reviewed
Apr 1, 2023
packages/velaux-ui/src/pages/ApplicationInstanceList/components/ContainerLog/index.tsx
Outdated
Show resolved
Hide resolved
barnettZQG
reviewed
Apr 1, 2023
packages/velaux-ui/src/pages/ApplicationLog/components/LogContainer/index.tsx
Show resolved
Hide resolved
Signed-off-by: Basuotian <[email protected]>
barnettZQG
reviewed
Apr 3, 2023
Signed-off-by: Basuotian <[email protected]>
mujinhuakai
pushed a commit
to mujinhuakai/velaux
that referenced
this pull request
Apr 8, 2023
* feat: support download pod lods in velaux Signed-off-by: Basuotian <[email protected]> * make download function reusable Signed-off-by: Basuotian <[email protected]> * remove unused translation Signed-off-by: Basuotian <[email protected]> --------- Signed-off-by: Basuotian <[email protected]> Signed-off-by: liyanfang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Close: #720
preview:
I have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer