Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enhance the code style #732

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

barnettZQG
Copy link
Collaborator

Description of your changes

Add the rule for the Golang lint.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +10.55 🎉

Comparison is base (5e7c098) 49.79% compared to head (e27ccfe) 60.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #732       +/-   ##
===========================================
+ Coverage   49.79%   60.34%   +10.55%     
===========================================
  Files          99       99               
  Lines       17974    17966        -8     
===========================================
+ Hits         8950    10842     +1892     
+ Misses       7863     5787     -2076     
- Partials     1161     1337      +176     
Flag Coverage Δ
apiserver-unittests 32.25% <30.00%> (?)
server-e2e-tests 49.63% <50.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/plugin/registry/in_memory.go 95.74% <ø> (+25.53%) ⬆️
pkg/plugin/types/plugin.go 30.00% <0.00%> (-3.34%) ⬇️
pkg/server/config/config.go 0.00% <ø> (ø)
pkg/server/domain/service/definition.go 75.07% <ø> (+12.60%) ⬆️
pkg/server/interfaces/api/dto/v1/types.go 73.33% <ø> (+41.75%) ⬆️
pkg/server/server.go 55.02% <0.00%> (ø)
pkg/server/domain/service/plugin.go 65.11% <60.00%> (ø)
pkg/plugin/loader/loader.go 54.81% <100.00%> (+0.91%) ⬆️

... and 35 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@barnettZQG barnettZQG merged commit ce2a5f8 into kubevela:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant