Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove the dependency package node-sass #705

Merged
merged 3 commits into from
Mar 18, 2023

Conversation

barnettZQG
Copy link
Collaborator

Description of your changes

We migrate Node Sass to Dart Sass: just replace node-sass in your package.json file with sass. Both packages expose the same JavaScript API.

Node Sass doesn't support Linux/arm64 or Mac-m1.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (757e727) 58.83% compared to head (e184f97) 58.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   58.83%   58.87%   +0.03%     
==========================================
  Files          94       94              
  Lines       17596    17596              
==========================================
+ Hits        10352    10359       +7     
+ Misses       5925     5921       -4     
+ Partials     1319     1316       -3     
Flag Coverage Δ
apiserver-unittests 32.16% <ø> (+0.09%) ⬆️
server-e2e-tests 44.85% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@barnettZQG barnettZQG merged commit 7ed1897 into kubevela:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant