Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add note for make reviewable in Prerequisites section of Code Contrib… #1336

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

kanchan-dhamane
Copy link
Contributor

Add note for make reviewable in Prerequisites section of Code Contribution Guide Page

I have:

  • Read and followed KubeVela's contribution process.
  • Update sidebar.js if adding a new page.
  • Run yarn start to ensure the changes has taken effect.

Copy link
Contributor

@anoop2811 anoop2811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FogDong FogDong merged commit 8e4a45f into kubevela:main Jul 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants