Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the install scripts now picks the latest version and binary from… #1255

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

anoop2811
Copy link
Contributor

… github (#1254)

  • also fixed the kubectl-vela install script

Description of your changes

Fixes #1254 : Update the script to pick the latest version from github

I have:

  • [x ] Read and followed KubeVela's contribution process.
  • [ x] Update sidebar.js if adding a new page.
  • [ x] Run yarn start to ensure the changes has taken effect.

… github (kubevela#1254)

- also fixed the kubectl-vela install script

Signed-off-by: Anoop Gopalakrishnan <[email protected]>
Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We also need to update the documentation in the installation page.

@anoop2811
Copy link
Contributor Author

Thanks! We also need to update the documentation in the installation page.

Yes, I was hoping to get the script in and then use the github raw file url in the doc. Or I could extrapolate the path and update this commit. @wonderflow : WDYT?

@wonderflow
Copy link
Contributor

Sure, we can merge this pull request frist after the CI checks passed. Then we can verify the installation script before update the documentation.

@anoop2811
Copy link
Contributor Author

@wonderflow : I went ahead and updated the links to use kubevela.io for the scripts as well.

@wonderflow wonderflow merged commit 823d9d3 into kubevela:main Jul 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the vela cli install script to pick the latest version from github
2 participants