π± knative: Using nodeSelector/tolerations with Serving?#1395
Closed
clubanderson wants to merge 1 commit intomasterfrom
Closed
π± knative: Using nodeSelector/tolerations with Serving?#1395clubanderson wants to merge 1 commit intomasterfrom
clubanderson wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
π Mission Scan Resultsπ
|
| Type | Match |
|---|---|
| Command injection: backtick | \bash |
| kubectl get pods -n knative -l app.kubernetes.io/name=knative | |
| helm list -n knative 2>/dev/null || echo "Not installed via Helm" | |
| `` |
Contributor
Author
|
Closing: accuracy review found the linked source PR was closed without merging. The resolution content references an unmerged PR and is misleading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π± New Mission: knative β Using nodeSelector/tolerations with Serving?
Type: feature | Source: knative/serving#1816 (33 reactions)
Fix PR: knative/serving#1831
File:
solutions/cncf-generated/knative/knative-1816-using-nodeselector-tolerations-with-serving.jsonCopilot: Please enhance this mission
The JSON file has been pre-filled with content from the source issue. Please improve:
node scripts/scanner.mjsto validateAuto-generated by CNCF Mission Generator