Skip to content

🌱 knative: Using nodeSelector/tolerations with Serving?#1395

Closed
clubanderson wants to merge 1 commit intomasterfrom
cncf-mission/knative-1816-using-nodeselector-tolerations-with-serving
Closed

🌱 knative: Using nodeSelector/tolerations with Serving?#1395
clubanderson wants to merge 1 commit intomasterfrom
cncf-mission/knative-1816-using-nodeselector-tolerations-with-serving

Conversation

@clubanderson
Copy link
Contributor

🌱 New Mission: knative β€” Using nodeSelector/tolerations with Serving?

Type: feature | Source: knative/serving#1816 (33 reactions)
Fix PR: knative/serving#1831
File: solutions/cncf-generated/knative/knative-1816-using-nodeselector-tolerations-with-serving.json

Copilot: Please enhance this mission

The JSON file has been pre-filled with content from the source issue. Please improve:

  1. Make step descriptions more specific with exact commands for this issue
  2. Add the exact error message to the description if missing
  3. Explain the root cause in the resolution summary
  4. Add relevant YAML/code snippets to codeSnippets if missing
  5. Run node scripts/scanner.mjs to validate

Auto-generated by CNCF Mission Generator

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@clubanderson clubanderson added ai-fix-requested Copilot coding agent should work on this cncf-mission-gen Auto-generated CNCF mission request triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 18, 2026
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Mar 18, 2026
@kubestellar-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2026
@github-actions
Copy link
Contributor

πŸ” Mission Scan Results

πŸ“„ solutions/cncf-generated/knative/knative-1816-using-nodeselector-tolerations-with-serving.json

βœ… Schema: Valid kc-mission-v1

βœ… Sensitive data: None detected

🚨 Security: 1 finding(s)

Type Match
Command injection: backtick \bash
kubectl get pods -n knative -l app.kubernetes.io/name=knative
helm list -n knative 2>/dev/null || echo "Not installed via Helm"
``

@clubanderson
Copy link
Contributor Author

Closing: accuracy review found the linked source PR was closed without merging. The resolution content references an unmerged PR and is misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-fix-requested Copilot coding agent should work on this cncf-mission-gen Auto-generated CNCF mission request dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants