add mutatingwebhook #104
Merged
add mutatingwebhook #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-ci-bot
added
do-not-merge/work-in-progress
soulseen
force-pushed
the
improve/mutating
branch
3 times, most recently
from
e330a27
to
0e9b542
Compare
ks-ci-bot
added
size/L
ks-ci-bot
removed
the
do-not-merge/work-in-progress
|
/cc @magicsong @runzexia |
runzexia
reviewed
Sep 23, 2019
pkg/webhook/default_server/s2ibuilder/mutating/s2ibuilder_create_update_handler.go
Outdated
Show resolved
Hide resolved
Signed-off-by: zhuxiaoyang <[email protected]>
soulseen
force-pushed
the
improve/mutating
branch
from
0e9b542
to
c962f2a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runzexia, soulseen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
soulseen
pushed a commit
that referenced
this pull request
Sep 23, 2019
This reverts commit 03a80ec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mutating control to S2ibuilder to fill some default values.#7
Signed-off-by: zhuxiaoyang [email protected]