Skip to content

feat: handle large object storage by clearing spec and updating annotations #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthyx merged 1 commit into from
Jan 22, 2026
Merged

feat: handle large object storage by clearing spec and updating annotations #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions pkg/registry/file/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,22 @@ func (s *StorageImpl) CreateWithConn(ctx context.Context, conn *sqlite.Conn, key
ctx = context.WithValue(ctx, connKey, conn)
// call processor on object to be saved
if err := s.processor.PreSave(ctx, obj); err != nil {
return err
if errors.Is(err, ObjectTooLargeError) {
// clear spec to not bloat the storage
clearSpec(obj)
// update annotations with the new state
metadata := obj.(metav1.Object)
annotations := metadata.GetAnnotations()
if annotations == nil {
annotations = make(map[string]string)
}
annotations[helpersv1.StatusMetadataKey] = helpersv1.TooLarge
metadata.SetAnnotations(annotations)
logger.L().Debug("Create - too large object, saving metadata only", helpers.String("key", key))
// we don't return here as we still need to save the object with updated annotations
} else {
return err
}
}
// save object
if err := s.saveObject(conn, key, obj, metaOut, ""); err != nil {
Expand Down Expand Up @@ -765,11 +780,14 @@ func (s *StorageImpl) GuaranteedUpdateWithConn(
// call processor on object to be saved
if err := s.processor.PreSave(ctx, ret); err != nil {
if errors.Is(err, ObjectTooLargeError) {
// revert spec
ret = origState.obj.DeepCopyObject() // FIXME this is expensive
// clear spec to not bloat the storage
clearSpec(ret)
// update annotations with the new state
metadata := ret.(metav1.Object)
annotations := metadata.GetAnnotations()
if annotations == nil {
annotations = make(map[string]string)
}
annotations[helpersv1.StatusMetadataKey] = helpersv1.TooLarge
metadata.SetAnnotations(annotations)
logger.L().Debug("GuaranteedUpdate - too large object, skipping update", helpers.String("key", key))
Expand Down Expand Up @@ -955,3 +973,16 @@ func (immutableStorage) RequestWatchProgress(context.Context) error { return nil
func (immutableStorage) Versioner() storage.Versioner {
return storage.APIObjectVersioner{}
}

func clearSpec(obj runtime.Object) {
v := reflect.ValueOf(obj)
for v.Kind() == reflect.Ptr {
v = v.Elem()
}
if v.Kind() == reflect.Struct {
f := v.FieldByName("Spec")
if f.IsValid() && f.CanSet() {
f.Set(reflect.Zero(f.Type()))
}
}
}
Loading