fix: downgrade field not found log from warning to debug#750
fix: downgrade field not found log from warning to debug#750
Conversation
The warning was firing on every iouring event because the iouring gadget datasource has no "identifier" field, flooding logs (~97% of all log lines on affected nodes). Made-with: Cursor Signed-off-by: Ben <ben@armosec.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single logging level change in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
|
Closing - this suppressed the symptom instead of fixing the root cause. Will open a new PR with the proper fix. |
Summary
getFieldAccessorfunction was logging aWarningevery time a datasource field was missingidentifierfield, causing this warning to fire on every single iouring eventFix
Downgrade the log level from
WarningtoDebug. Missing fields are handled gracefully by thenullFieldAccessoralready, so this is not an actionable warning for operators — it's only useful when debugging.Test plan
field not foundno longer appears inkubectl logsat default log levelMade with Cursor
Summary by CodeRabbit