Skip to content

fix: downgrade field not found log from warning to debug#750

Closed
slashben wants to merge 1 commit intomainfrom
fix/iouring-field-not-found-log-noise
Closed

fix: downgrade field not found log from warning to debug#750
slashben wants to merge 1 commit intomainfrom
fix/iouring-field-not-found-log-noise

Conversation

@slashben
Copy link
Copy Markdown
Contributor

@slashben slashben commented Mar 17, 2026

Summary

  • The getFieldAccessor function was logging a Warning every time a datasource field was missing
  • The iouring gadget datasource has no identifier field, causing this warning to fire on every single iouring event
  • On affected nodes this accounted for ~97% of all node-agent log lines (~6249 out of 6433)

Fix

Downgrade the log level from Warning to Debug. Missing fields are handled gracefully by the nullFieldAccessor already, so this is not an actionable warning for operators — it's only useful when debugging.

Test plan

  • Deploy node-agent and verify iouring events are still processed correctly
  • Confirm field not found no longer appears in kubectl logs at default log level

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted logging level for missing field scenarios to reduce noise in logs while maintaining functionality.

The warning was firing on every iouring event because the iouring
gadget datasource has no "identifier" field, flooding logs (~97% of
all log lines on affected nodes).

Made-with: Cursor
Signed-off-by: Ben <ben@armosec.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e7cced83-56eb-4f58-890f-4aa91c6ae5ab

📥 Commits

Reviewing files that changed from the base of the PR and between f673d45 and a573064.

📒 Files selected for processing (1)
  • pkg/utils/datasource_event.go

📝 Walkthrough

Walkthrough

A single logging level change in DatasourceEvent.getFieldAccessor reduces the severity of missing field notifications from Warning to Debug when a requested field is not found in the datasource.

Changes

Cohort / File(s) Summary
Logging Level Adjustment
pkg/utils/datasource_event.go
Modified log level from Warning to Debug when a field accessor is not found during datasource event processing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A warning became whisper, a shout turned to sigh,
The logs speak more gently when fields pass us by,
Debug now befits what we quietly need,
Less noise in the warnings, a gentle-eared read! 📝✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: downgrading a log level from warning to debug for missing datasource fields, which directly matches the primary change in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/iouring-field-not-found-log-noise
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

@slashben
Copy link
Copy Markdown
Contributor Author

Closing - this suppressed the symptom instead of fixing the root cause. Will open a new PR with the proper fix.

@slashben slashben closed this Mar 17, 2026
@slashben slashben deleted the fix/iouring-field-not-found-log-noise branch March 17, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant