Skip to content

Generate release#687

Closed
slashben wants to merge 2 commits intomainfrom
feature/add-is-trigger-alert-propagation
Closed

Generate release#687
slashben wants to merge 2 commits intomainfrom
feature/add-is-trigger-alert-propagation

Conversation

@slashben
Copy link
Copy Markdown
Contributor

@slashben slashben commented Jan 18, 2026

Build Process Improvement:

  • Changed the docker-push target in the Makefile to depend on docker-build, ensuring the image is built before pushing.

Summary by CodeRabbit

Release Notes

  • New Features

    • Added trigger alert identification to rule failures, enabling detection of trigger-based alerts in the system
  • Chores

    • Updated external dependencies
    • Enhanced Docker build workflow to ensure proper build sequence

✏️ Tip: You can customize this high-level summary in your review settings.

- Update armoapi-go dependency to v0.0.663 (includes IsTriggerAlert in RuntimeAlert)
- Add IsTriggerAlert field to GenericRuleFailure struct
- Add GetIsTriggerAlert/SetIsTriggerAlert methods to RuleFailure interface
- Copy IsTriggerAlert from rule to failure in CreateRuleFailure
- Copy IsTriggerAlert from failure to alert in createRuleAlert
Signed-off-by: Ben <ben@armosec.io>
Signed-off-by: Ben <ben@armosec.io>
@slashben slashben added the release Create release label Jan 18, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 18, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes introduce a new IsTriggerAlert boolean flag that propagates through the rule failure and alert pipeline. The flag is added to the GenericRuleFailure data structure with getter/setter methods, initialized during rule failure creation, and ultimately populated in HTTP-exported RuntimeAlert payloads. Additionally, the Makefile docker-push target is updated to depend on docker-build, and an external Go dependency is bumped to a newer version.

Changes

Cohort / File(s) Summary
Build and Dependency Updates
Makefile, go.mod
Makefile: docker-push target now depends on docker-build (previously standalone). go.mod: Updated armosec/armoapi-go dependency from v0.0.654 to v0.0.663
Rule Failure Flag Infrastructure
pkg/rulemanager/types/failure.go
Added IsTriggerAlert field to GenericRuleFailure struct and implemented GetIsTriggerAlert() and SetIsTriggerAlert() methods on both the RuleFailure interface and GenericRuleFailure concrete type
Rule Failure Flag Propagation
pkg/rulemanager/ruleadapters/creator.go, pkg/exporters/http_exporter.go
creator.go: Initializes IsTriggerAlert from rule.IsTriggerAlert in CreateRuleFailure. http_exporter.go: Populates IsTriggerAlert field in RuntimeAlert payload using failedRule.GetIsTriggerAlert()

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • amirmalka

Poem

🐰 A flag hops through the system bright,
IsTriggerAlert set just right,
Through failures and exports it flows,
Docker builds before push goes,
Dependencies updated with care!

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@slashben slashben closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Create release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant