Skip to content

feat: propagate IsTriggerAlert field from rules to runtime alerts #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slashben merged 1 commit into from
Jan 18, 2026
Merged

feat: propagate IsTriggerAlert field from rules to runtime alerts #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require (
github.com/Masterminds/semver/v3 v3.4.0
github.com/anchore/syft v1.32.0
github.com/aquilax/truncate v1.0.0
github.com/armosec/armoapi-go v0.0.654
github.com/armosec/armoapi-go v0.0.663
github.com/armosec/utils-k8s-go v0.0.35
github.com/cenkalti/backoff v2.2.1+incompatible
github.com/cenkalti/backoff/v4 v4.3.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,8 +761,8 @@ github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod h1:ufUuZ+zHj
github.com/armon/go-radix v1.0.0/go.mod h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8=
github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5 h1:0CwZNZbxp69SHPdPJAN/hZIm0C4OItdklCFmMRWYpio=
github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5/go.mod h1:wHh0iHkYZB8zMSxRWpUBQtwG5a7fFgvEO+odwuTv2gs=
github.com/armosec/armoapi-go v0.0.654 h1:ALtMYLhvv9gUxYd9I/nyoxb7Pzo+uscmKyxjKbdp5Lc=
github.com/armosec/armoapi-go v0.0.654/go.mod h1:9jAH0g8ZsryhiBDd/aNMX4+n10bGwTx/doWCyyjSxts=
github.com/armosec/armoapi-go v0.0.663 h1:Ht8eBIY8y3VbFhtvfzdwjMsgiVX7K3dURp6qfBwz8Jo=
github.com/armosec/armoapi-go v0.0.663/go.mod h1:9jAH0g8ZsryhiBDd/aNMX4+n10bGwTx/doWCyyjSxts=
github.com/armosec/gojay v1.2.17 h1:VSkLBQzD1c2V+FMtlGFKqWXNsdNvIKygTKJI9ysY8eM=
github.com/armosec/gojay v1.2.17/go.mod h1:vuvX3DlY0nbVrJ0qCklSS733AWMoQboq3cFyuQW9ybc=
github.com/armosec/utils-go v0.0.58 h1:g9RnRkxZAmzTfPe2ruMo2OXSYLwVSegQSkSavOfmaIE=
Expand Down
1 change: 1 addition & 0 deletions pkg/exporters/http_exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ func (e *HTTPExporter) createRuleAlert(failedRule types.RuleFailure) apitypes.Ru
RuntimeAlertK8sDetails: k8sDetails,
RuleAlert: failedRule.GetRuleAlert(),
RuleID: failedRule.GetRuleId(),
IsTriggerAlert: failedRule.GetIsTriggerAlert(),
HttpRuleAlert: httpDetails,
}
}
Expand Down
5 changes: 3 additions & 2 deletions pkg/rulemanager/ruleadapters/creator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ func (r *RuleFailureCreator) CreateRuleFailure(rule typesv1.Rule, enrichedEvent
RuleAlert: apitypes.RuleAlert{
RuleDescription: message,
},
RuleID: rule.ID,
AlertPlatform: apitypes.AlertSourcePlatformK8s,
RuleID: rule.ID,
AlertPlatform: apitypes.AlertSourcePlatformK8s,
IsTriggerAlert: rule.IsTriggerAlert,
}

eventAdapter.SetFailureMetadata(ruleFailure, enrichedEvent, state)
Expand Down
13 changes: 13 additions & 0 deletions pkg/rulemanager/types/failure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type GenericRuleFailure struct {
CloudServices []string
HttpRuleAlert apitypes.HttpRuleAlert
Extra interface{}
IsTriggerAlert bool
}

type RuleFailure interface {
Expand Down Expand Up @@ -69,6 +70,10 @@ type RuleFailure interface {
SetHttpRuleAlert(httpRuleAlert apitypes.HttpRuleAlert)
// Set Extra
SetExtra(extra interface{})
// Get IsTriggerAlert
GetIsTriggerAlert() bool
// Set IsTriggerAlert
SetIsTriggerAlert(isTriggerAlert bool)
}

func (rule *GenericRuleFailure) GetBaseRuntimeAlert() apitypes.BaseRuntimeAlert {
Expand Down Expand Up @@ -162,3 +167,11 @@ func (rule *GenericRuleFailure) SetHttpRuleAlert(httpRuleAlert apitypes.HttpRule
func (rule *GenericRuleFailure) SetExtra(extra interface{}) {
rule.Extra = extra
}

func (rule *GenericRuleFailure) GetIsTriggerAlert() bool {
return rule.IsTriggerAlert
}

func (rule *GenericRuleFailure) SetIsTriggerAlert(isTriggerAlert bool) {
rule.IsTriggerAlert = isTriggerAlert
}
Loading