Skip to content

Feature/refactor rule engine #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 121 commits into
base: main
Choose a base branch
from
Open

Feature/refactor rule engine #601

wants to merge 121 commits into from

Conversation

afek854
Copy link
Contributor

@afek854 afek854 commented Aug 4, 2025

Overview

afek854 and others added 30 commits July 24, 2025 13:52
@afek854
added interfaces for rule manager refactor
d5be2e9 
Signed-off-by: Afek Berger <[email protected]>
@afek854
added structure
eddcef6 
Signed-off-by: Afek Berger <[email protected]>
@afek854
added profile validator
f350c8a 
Signed-off-by: Afek Berger <[email protected]>
@afek854
added v1
531da25 
Signed-off-by: Afek Berger <[email protected]>
@afek854
added profile validators
a0c3245 
Signed-off-by: Afek Berger <[email protected]>
@amitschendel
go mod tidy
d2c6899 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Adding base helpers pkg
13331e4 
Signed-off-by: Amit Schendel <[email protected]>
@afek854
added rule failure creator and changed rule_manager logic
92cd0b2 
Signed-off-by: Afek Berger <[email protected]>
@amitschendel
Adding lib
9c36107 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Caching programs
021a6aa 
Signed-off-by: Amit Schendel <[email protected]>
@afek854
integrate new rule manager
197b7da 
Signed-off-by: Afek Berger <[email protected]>
@amitschendel
Merge branch 'feature/refactor_rule_engine' into dev/rre
c9f6110 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Resolving conflicts
cfab916 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Adding crd
151c993 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Dev/rre (#594)
7a9f009 
* go mod tidy

Signed-off-by: Amit Schendel <[email protected]>

* Adding base helpers pkg

Signed-off-by: Amit Schendel <[email protected]>

* Adding lib

Signed-off-by: Amit Schendel <[email protected]>

* Caching programs

Signed-off-by: Amit Schendel <[email protected]>

* Resolving conflicts

Signed-off-by: Amit Schendel <[email protected]>

* Adding crd

Signed-off-by: Amit Schendel <[email protected]>

---------

Signed-off-by: Amit Schendel <[email protected]>
Signed-off-by: Amit Schendel <[email protected]>
@afek854
organized imports
289e81a 
Signed-off-by: Afek Berger <[email protected]>
@afek854
added watcher & tests
9edf8c5 
Signed-off-by: Afek Berger <[email protected]>
@afek854
added watcher and integration with binding
001c265 
Signed-off-by: Afek Berger <[email protected]>
@amitschendel
Changing types
c62f51b 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Defining types
ffc45cf 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Fixing code
a0c86a9 
Signed-off-by: Amit Schendel <[email protected]>
@afek854
merged
4e297ae 
Signed-off-by: Afek Berger <[email protected]>
@afek854
fixed container name
62e82bf 
Signed-off-by: Afek Berger <[email protected]>
@afek854
fixed conflicts
e79fd44 
Signed-off-by: Afek Berger <[email protected]>
@afek854
separated mock
f1419d2 
Signed-off-by: Afek Berger <[email protected]>
@afek854
fixed watcher & create event with check struct
e719619 
Signed-off-by: Afek Berger <[email protected]>
@amitschendel
Changing event
8cf32cf 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Updating code
9550178 
Signed-off-by: Amit Schendel <[email protected]>
@afek854
modify cel arguments & events check struct
dce926b 
Signed-off-by: Afek Berger <[email protected]>
@amitschendel
Adding some code
efd6a1e 
Signed-off-by: Amit Schendel <[email protected]>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

amitschendel
amitschendel reviewed Aug 27, 2025
View reviewed changes
pkg/containerwatcher/container_watcher_interface.go
) (TracerInterface, error)
}

type GenericEventReceiver interface { // TODO: either EventReceiver or EnrichedEventReceiver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

@afek854
added container receivers
4943734 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/refactor_rule_engine branch from 56e28dd to 4943734 Compare August 27, 2025 14:33
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

1 similar comment
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@afek854 afek854 force-pushed the feature/refactor_rule_engine branch from 4722604 to a1406bd Compare August 31, 2025 09:06
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@afek854 afek854 force-pushed the feature/refactor_rule_engine branch 3 times, most recently from d61713b to 792c92c Compare August 31, 2025 10:34
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@afek854
updated rule names
b21bf9b 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/refactor_rule_engine branch from 792c92c to b21bf9b Compare August 31, 2025 10:47
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@amitschendel
Fixing Identifiers of http
5d04059 
Signed-off-by: Amit Schendel <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

@matthyx
add RuleManagerMock
94428ae 
Signed-off-by: Matthias Bertschy <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

@amitschendel
Adding host check for http
66b1ac4 
Signed-off-by: Amit Schendel <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

@matthyx
refactor: update tracer configuration to use typed config parameters
89e2521 
Signed-off-by: Matthias Bertschy <[email protected]>
@matthyx
Merge pull request #647 from kubescape/fix-config
3d6a003 
refactor: update tracer configuration to use typed config parameters
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitschendel amitschendel amitschendel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
KS PRs tracking
Status: WIP
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afek854 @amitschendel @matthyx