Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version for PriorityClass #9321

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

hardikdr
Copy link
Member

@hardikdr hardikdr commented Jun 29, 2018

With K8s 1.11 it should be scheduling.k8s.io/v1beta1

With K8s 1.11 it should be `scheduling.k8s.io/v1beta1`
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit abd1a02

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b3606a6dd28ef5966d72029

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 29, 2018
@tengqm
Copy link
Contributor

tengqm commented Jul 17, 2018

/lgtm
Encountered this when reworking the API reference doc generator.
/assign @MistyHacks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2018
@mdlinville
Copy link
Contributor

/approve

@tengqm Ideally when would this have been caught and by whom, during the 1.11 cycle?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit e19980f into kubernetes:release-1.11 Jul 17, 2018
@tengqm
Copy link
Contributor

tengqm commented Jul 18, 2018

@MistyHacks I only found this when I was working on the "native" API reference doc generator (kubernetes-sigs/reference-docs#53). I copied the OpenAPI JSON file out of kubernetes/kubernetes release-1.11 branch and ran it against the doc generator, and I got an error that the PriorityClass beta version is not found in TOC (thanks to the cross checking logic in the generator). I have no idea how this happened because we already regenerated the API ref doc when release-1.11 was out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants