Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate _headers file #9173

Closed
wants to merge 1 commit into from
Closed

Auto-generate _headers file #9173

wants to merge 1 commit into from

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Jun 20, 2018

At the moment, Netlify deployment includes copying a file from the root into the public folder. This PR introduces changes that generate the _headers file from a template. Right now the template doesn't include any special logic (it's essentially just the original text file) but this setup will enable us to generate a more fine-grained _headers file in the future.

Testing

I've tested this locally via the following steps:

$ rm -rf public
$ hugo
$ cat public/_headers
/*
  X-Robots-Tag: noindex

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: steveperry-53

Assign the PR to them by writing /assign @steveperry-53 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 81f1e41

https://deploy-preview-9173--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 20, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit af949d1

https://deploy-preview-9173--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2018
@lucperkins lucperkins changed the title Add _headers file into static folder Auto-generate _headers file Jun 20, 2018
@lucperkins
Copy link
Contributor Author

I'm going to close this PR in favor of #9225, which includes these changes but is more comprehensive.

@lucperkins lucperkins closed this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants