Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #7642

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Fix typo #7642

merged 1 commit into from
Mar 6, 2018

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Mar 5, 2018 •
edited
Loading

Typo fixes for the versions containing this doc:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2018
This was referenced Mar 5, 2018
Merged
Merged
Merged
@mtaufen
Copy link
Contributor Author

mtaufen commented Mar 5, 2018

/assign @steveperry-53

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for k8sio-v1-8 ready!

Built with commit 31f9eb0

https://deploy-preview-7642--k8sio-v1-8.netlify.com

@mtaufen
Copy link
Contributor Author

mtaufen commented Mar 5, 2018

/cc @pdecat

@k8s-ci-robot
Copy link
Contributor

@mtaufen: GitHub didn't allow me to request PR reviews from the following users: pdecat.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pdecat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bradtopol bradtopol self-assigned this Mar 5, 2018
@bradtopol
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2018
@bradtopol
Copy link
Contributor

@zacharysarah ready for you

@zacharysarah
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4fb1b68 into kubernetes:release-1.8 Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm Awaiting requested review from tengqm

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@zacharysarah zacharysarah

@bradtopol bradtopol

@steveperry-53 steveperry-53

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mtaufen @k8sio-netlify-preview-bot @k8s-ci-robot @bradtopol @zacharysarah @steveperry-53