Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc on how to configure Kubelet with a file #5694

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Sep 29, 2017

Follow up to #5523 that describes how to load Kubelet configuration from a file.


This change is Reviewable

@mtaufen mtaufen added this to the v1.8 milestone Sep 29, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Sep 29, 2017

Deploy preview ready!

Built with commit 16adbc1

https://deploy-preview-5694--kubernetes-io-master-staging.netlify.com

@mtaufen mtaufen force-pushed the kubelet-config-file-docs branch from 2c8d64b to 5411b29 Compare September 29, 2017 23:13
is defined by the `KubeletConfiguration` struct
[here (v1alpha1)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/kubeletconfig/v1alpha1/types.go).
The configuration file must be a JSON or YAML representation of the parameters
in this struct. Note that that this structure, and thus the config file API,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that that -> that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

[here (v1alpha1)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/kubeletconfig/v1alpha1/types.go).
The configuration file must be a JSON or YAML representation of the parameters
in this struct. Note that that this structure, and thus the config file API,
is still considured alpha and is not subject to stability gurarantees.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considured -> considered

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Kubelet's `--init-config-dir` flag set to the location of the directory
containing the `kubelet` file. The Kubelet will then load the parameters defined
by `KubeletConfiguration` from the `kubelet` file, rather than from their
associated command-line flags.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so settings in the configuration file take precedence of the command line flags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.


## Relationship to Dynamic Kubelet Config

If you are using the [Dynamic Kubelet Configuration](https://github.com/kubernetes/features/issues/281)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we here use the link shown above Reconfigure a Node's Kubelet in a Live Cluster. Referring to issues on github.com is not end user friendly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

feature, the configuration provided via `--init-config-dir` will be considered
the "last known good" configuration by the automatic rollback mechanism.

Note that the layout of the files in the `--init-conifg-dir` mirrors the layout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: --init-config-dir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Done.

@steveperry-53
Copy link
Contributor

@mtaufen Aside from typos mentioned by @tengqm, Docs LGTM.

@mtaufen mtaufen force-pushed the kubelet-config-file-docs branch from 5411b29 to 16adbc1 Compare October 10, 2017 16:22
@mtaufen
Copy link
Contributor Author

mtaufen commented Oct 10, 2017

Updated PTAL

@steveperry-53
Copy link
Contributor

@mtaufen Docs LGTM. I'll merge this as soon as we get official tech approval from @tengqm.

@mtaufen
Copy link
Contributor Author

mtaufen commented Oct 10, 2017

SG, thanks Steve!

@tengqm
Copy link
Contributor

tengqm commented Oct 12, 2017

/lgtm

Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, 👍

@steveperry-53 steveperry-53 merged commit 8da72ca into kubernetes:master Oct 12, 2017
@chenopis chenopis modified the milestones: v1.8, 1.8 Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants