Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config for 1.8 release. #5661

Merged
merged 2 commits into from
Sep 28, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ defaults:
githubbranch: "master"
docsbranch: "master"
versions:
- fullversion: "v1.8.0"
version: "v1.8"
githubbranch: "release-1.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set githubbranch to v1.8.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but I don't understand what branch that is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the GitHub branch from the main Kubernetes repo. If you do a search in the docs, you can see, for example, that in /docs/admin/authorization/abac.md, there is a link that uses that variable:

[Complete file example](http://releases.k8s.io/{{page.githubbranch}}/pkg/auth/authorizer/abac/example_policy_file.jsonl)

docsbranch: "release-1.8"
url: https://kubernetes.io/docs/home/
- fullversion: "v1.7.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, set fullversion to v1.7.6 as per the most current version in the CHANGELOG.

Also, set the url for v1.7.x to https://kubernetes-io-v1-7.netlify.com/docs/home/ until we can get @thockin to setup a subdomain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

version: "v1.7"
githubbranch: "v1.7.3"
Expand Down