DRA resourcepoolstatusrequest - #56352
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @nmn3m 👋! v1.37 Docs team here We noticed that this Pull Request is currently in the Open state. Note Could you please confirm:
Important Upcoming Docs Deadlines:
Please let us know so we can track this accurately on our end. Thanks! |
|
@kernel-kun |
|
/wg device-management |
…ol-status-request # Conflicts: # content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
|
/cc @johnbelamaric |
johnbelamaric
left a comment
There was a problem hiding this comment.
/approve
for DRA content
|
/cc @natalisucks |
|
/sig docs |
| - `partitionSummary`: for [partitionable](/docs/concepts/resource-management/dynamic-resource-allocation/dra-features/#partitionable-devices) | ||
| pools, per-partition-type allocatability (see | ||
| [Partition and shareable summaries](#resource-pool-partition-shareable-summaries)). | ||
| - `shareableSummary`: for pools with shareable devices, aggregate capacity |
There was a problem hiding this comment.
Does this map to the DRAConsumableCapacity feature? If so, could we link to those docs at /docs/concepts/resource-management/dynamic-resource-allocation/dra-features/#consumable-capacity like you have for partitionable devices?
| slice) that draw from the same shared counters. Because these partitions compete | ||
| for the same underlying capacity, a plain device count does not tell you how many | ||
| of each type can still be allocated. The `partitionSummary` view answers that | ||
| question: for each partition type it reports: |
There was a problem hiding this comment.
nit: The double colon feels a bit clunky. A new sentence might flow better.
| question: for each partition type it reports: | |
| question. For each partition type it reports: |
| - `attribute`: the fully qualified device attribute name whose value groups this | ||
| entry. | ||
| - `type`: the partition type value (for example, `Full` or `Half`). |
There was a problem hiding this comment.
Could the docs mention where these values come from? i.e. that attribute matches the ResourceSlice's spec.partitionTypeAttribute or ResourcePoolStatusRequest's spec. defaultPartitionTypeAttribute and type is the value of that attribute. I think that would help tie in the examples below.
| ### Partition and shareable summaries {#resource-pool-partition-shareable-summaries} | ||
|
|
||
| {{< feature-state feature_gate_name="DRAPartitionableDevicesType" >}} |
There was a problem hiding this comment.
Would it make sense to split this into separate sections for partitionable devices and shareable devices? Especially if the shareable summaries aren't tied to the DRAPartitionableDevicesType feature gate.
| - `attribute`: the fully qualified device attribute name whose value groups this | ||
| entry. |
There was a problem hiding this comment.
Can this attribute only be of type string or are other types converted before being represented in the type field? It might also be worth calling out how this interacts with the DRAListTypeAttributes feature, or if those aren't handled.
These would also be good to mention in the API docs.
There was a problem hiding this comment.
- String only. It reads only attr.StringValue; if that's nil (int, bool, version or absent), it returns no partition type. Nothing is converted/stringified. Such a device then produces a PartitionTypeMissing validation error for the pool instead of a partition summary.
- No DRAListTypeAttributes interaction. No shared code path a list-type attribute has StringValue == nil, so it's treated like any other non-string attribute. Not special-cased.
…ng and string-type requirement
nojnhuh
left a comment
There was a problem hiding this comment.
Just one more small comment. Otherwise looking good, thanks!
|
|
||
| **Shareable summary.** For pools that contain devices allowing multiple | ||
| allocations, `shareableSummary` reports aggregate capacity usage across the pool: | ||
| The `partitionSummary` view is an *alpha feature*. In addition to the |
There was a problem hiding this comment.
#56295 dropped the inline alpha/beta qualifier in text like this in favor of the rendered feature-state components. Features tend to be described like this now:
cc @nojnhuh Thanks for the feedback. |
|
LGTM label has been added. DetailsGit tree hash: 6fcb443a62e971e621ae7300e2d1163c564d0641 |
|
/approve Thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, katcosgrove, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
DRA Resource Availability Visibility
Issue
kubernetes/enhancements#5677