Skip to content

Add docs for metrics.k8s.io graduation to stable - #56349

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes:dev-1.37from
tico88612:feat/metrics-k8s-io-v1
Aug 4, 2026
Merged

Add docs for metrics.k8s.io graduation to stable#56349
kubernetes-prow[bot] merged 2 commits into
kubernetes:dev-1.37from
tico88612:feat/metrics-k8s-io-v1

Conversation

@tico88612

@tico88612 tico88612 commented Jul 1, 2026

Copy link
Copy Markdown
Member

@kubernetes-prow kubernetes-prow Bot added this to the 1.37 milestone Jul 1, 2026
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2026
@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 1e6f856
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6a70ac3024b4e000086e6728

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2026
@kernel-kun

Copy link
Copy Markdown
Contributor

Thanks for opening the placeholder PR @tico88612, we've updated the tracking on our end!

@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1e6f856
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6a70ac30855188000802023c
😎 Deploy Preview https://deploy-preview-56349--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tico88612
tico88612 force-pushed the feat/metrics-k8s-io-v1 branch from c0c47aa to ccb2697 Compare July 9, 2026 01:18
@kubernetes-prow kubernetes-prow Bot added language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2026
@lmktfy

lmktfy commented Jul 11, 2026

Copy link
Copy Markdown
Member

As it's marked WIP already:
/retitle [WIP] Add docs for metrics.k8s.io graduation to stable

@kubernetes-prow kubernetes-prow Bot changed the title [WIP] Placeholder for v1.metrics.k8s.io [WIP] Add docs for metrics.k8s.io graduation to stable Jul 11, 2026
@jmickey

jmickey commented Jul 22, 2026

Copy link
Copy Markdown
Member

Hi @tico88612 👋! v1.37 Docs team here

We noticed that this Pull Request is currently in the Draft state.
If you haven't already, please go ahead and add the required documentation changes and move this PR from a Draft to Open state.

Important

Upcoming Docs Deadlines:

  • PR Ready for Review: Tuesday 28th July 2026
  • Docs Freeze: Wednesday 5th August 2026 (AoE) / Thursday 6th August 2026, 12:00 UTC

Thanks!

@tico88612
tico88612 marked this pull request as ready for review July 22, 2026 15:40
@kubernetes-prow
kubernetes-prow Bot requested review from piosz and reylejano July 22, 2026 15:40
@tico88612 tico88612 changed the title [WIP] Add docs for metrics.k8s.io graduation to stable Add docs for metrics.k8s.io graduation to stable Jul 22, 2026
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2026
@tico88612
tico88612 force-pushed the feat/metrics-k8s-io-v1 branch from ccb2697 to 0372c90 Compare July 22, 2026 17:17
@tico88612

Copy link
Copy Markdown
Member Author

cc @richabanker @rexagod @dgrisonnet as SIG Instrumentation Lead

@lmktfy lmktfy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the core project:

* [Metrics API (v1)](/docs/reference/external-api/metrics.v1/)
* [Metrics API (v1beta1)](/docs/reference/external-api/metrics.v1beta1/)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume that this one will become deprecated, but still be accepted for some time. Is that right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will likely never be deprecated. v1beta1 was the latest version of the feature for a decade so users relied on it as if it was stable

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are no plans for deprecation at the moment.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I have raised that with SIG Architecture - it doesn't sound right.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if users relied on it as if it was stable we can deprecate.

"Deprecate" means we recommend that where people can stop using it, they do so. I don't know why we wouldn't do that.

Comment thread content/en/docs/reference/_index.md Outdated
These are the APIs defined by the Kubernetes project, but are not implemented
by the core project:

* [Metrics API (v1)](/docs/reference/external-api/metrics.v1/)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This hyperlink doesn't actually work
  • A tricky one; we should check that there is a plan to update / add that page

@tico88612 tico88612 Aug 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to add it to this PR? or how to update this? (It looks like it hasn't been updated for 2 years.)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask in Slack (#release-docs) to check that there is at least an issue that covers the work required.

We can ship v1.37 even if there is no
https://k8s.io/docs/reference/external-api/metrics.v1/ page – but it shouldn't stay missing long.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to have the page under both sections?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different pages, but yes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the instrumentation section: its landing page does not currently contain Metrics API content. The closest related page is node-metrics, which documents the kubelet /metrics/resource endpoint rather than the aggregated metrics.k8s.io API.

Could you clarify what update you would like to see in this PR? Should I add a new Metrics API entry/page under the instrumentation section, or update node-metrics with a cross-link to the resource metrics pipeline documentation?

@SergeyKanzhelev

Copy link
Copy Markdown
Member

/sig instrumentation

@kubernetes-prow kubernetes-prow Bot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Jul 30, 2026
@dgrisonnet

Copy link
Copy Markdown
Member

For the technical side
/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: d090ee88b2f0075c8b125b814fc033773b63c69d

@tico88612

Copy link
Copy Markdown
Member Author

https://kubernetes.io/docs/concepts/workloads/autoscaling/horizontal-pod-autoscale/#support-for-metrics-apis

HPA doesn't support the metrics.k8s.io/v1 API yet (it's being worked on and needs to be reviewed by SIG Autoscaling), so there's no need to update this part for now.

@lmktfy

lmktfy commented Aug 2, 2026

Copy link
Copy Markdown
Member

https://kubernetes.io/docs/concepts/workloads/autoscaling/horizontal-pod-autoscale/#support-for-metrics-apis

HPA doesn't support the metrics.k8s.io/v1 API yet (it's being worked on and needs to be reviewed by SIG Autoscaling), so there's no need to update this part for now.

That doesn't sound right.

The update could be to document the limitation: that HPA doesn't support the metrics.k8s.io/v1 API. Readers could end up frustrated if we didn't mention that.

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612
tico88612 force-pushed the feat/metrics-k8s-io-v1 branch from 0372c90 to 1e6f856 Compare August 3, 2026 14:56
@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from dgrisonnet August 3, 2026 14:56
@tico88612

Copy link
Copy Markdown
Member Author

The update could be to document the limitation: that HPA doesn't support the metrics.k8s.io/v1 API. Readers could end up frustrated if we didn't mention that.

Added the description.

@katcosgrove

Copy link
Copy Markdown
Contributor

Since this had a previous tech LGTM aside from a small change:

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 7704fe1fd1c8e8e6b0bcbe50d4fde314ddc4c95a

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katcosgrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2026

## Metrics API
{{< feature-state for_k8s_version="1.8" state="beta" >}}
{{< feature-state for_k8s_version="1.37" state="stable" >}}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use fg name instead of manually change versions here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't have an FG name before; what's the best way to write it?

@kubernetes-prow
kubernetes-prow Bot merged commit 18ad3d9 into kubernetes:dev-1.37 Aug 4, 2026
6 checks passed
@tico88612
tico88612 deleted the feat/metrics-k8s-io-v1 branch August 7, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants