Add docs for metrics.k8s.io graduation to stable - #56349
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
|
Thanks for opening the placeholder PR @tico88612, we've updated the tracking on our end! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
c0c47aa to
ccb2697
Compare
|
As it's marked WIP already: |
|
Hi @tico88612 👋! v1.37 Docs team here We noticed that this Pull Request is currently in the Draft state. Important Upcoming Docs Deadlines:
Thanks! |
ccb2697 to
0372c90
Compare
|
cc @richabanker @rexagod @dgrisonnet as SIG Instrumentation Lead |
| by the core project: | ||
|
|
||
| * [Metrics API (v1)](/docs/reference/external-api/metrics.v1/) | ||
| * [Metrics API (v1beta1)](/docs/reference/external-api/metrics.v1beta1/) |
There was a problem hiding this comment.
I presume that this one will become deprecated, but still be accepted for some time. Is that right?
There was a problem hiding this comment.
It will likely never be deprecated. v1beta1 was the latest version of the feature for a decade so users relied on it as if it was stable
There was a problem hiding this comment.
Yes, there are no plans for deprecation at the moment.
There was a problem hiding this comment.
Ok. I have raised that with SIG Architecture - it doesn't sound right.
There was a problem hiding this comment.
Even if users relied on it as if it was stable we can deprecate.
"Deprecate" means we recommend that where people can stop using it, they do so. I don't know why we wouldn't do that.
| These are the APIs defined by the Kubernetes project, but are not implemented | ||
| by the core project: | ||
|
|
||
| * [Metrics API (v1)](/docs/reference/external-api/metrics.v1/) |
There was a problem hiding this comment.
- This hyperlink doesn't actually work
- A tricky one; we should check that there is a plan to update / add that page
There was a problem hiding this comment.
Do I need to add it to this PR? or how to update this? (It looks like it hasn't been updated for 2 years.)
There was a problem hiding this comment.
Ask in Slack (#release-docs) to check that there is at least an issue that covers the work required.
We can ship v1.37 even if there is no
https://k8s.io/docs/reference/external-api/metrics.v1/ page – but it shouldn't stay missing long.
There was a problem hiding this comment.
Already asked
ref: https://kubernetes.slack.com/archives/C0156PJ62RE/p1785663275611279
There was a problem hiding this comment.
Should we also update https://kubernetes.io/docs/reference/instrumentation/?
There was a problem hiding this comment.
is it ok to have the page under both sections?
There was a problem hiding this comment.
I checked the instrumentation section: its landing page does not currently contain Metrics API content. The closest related page is node-metrics, which documents the kubelet /metrics/resource endpoint rather than the aggregated metrics.k8s.io API.
Could you clarify what update you would like to see in this PR? Should I add a new Metrics API entry/page under the instrumentation section, or update node-metrics with a cross-link to the resource metrics pipeline documentation?
|
/sig instrumentation |
|
For the technical side |
|
LGTM label has been added. DetailsGit tree hash: d090ee88b2f0075c8b125b814fc033773b63c69d |
|
HPA doesn't support the |
That doesn't sound right. The update could be to document the limitation: that HPA doesn't support the |
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
0372c90 to
1e6f856
Compare
Added the description. |
|
Since this had a previous tech LGTM aside from a small change: /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 7704fe1fd1c8e8e6b0bcbe50d4fde314ddc4c95a |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: katcosgrove The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| ## Metrics API | ||
| {{< feature-state for_k8s_version="1.8" state="beta" >}} | ||
| {{< feature-state for_k8s_version="1.37" state="stable" >}} |
There was a problem hiding this comment.
use fg name instead of manually change versions here
There was a problem hiding this comment.
This didn't have an FG name before; what's the best way to write it?
Docs PR for kubernetes/enhancements#5207