[KEP-5941] DRASharedConsumableCapacity documentation - #56218
Conversation
Add documentation for the DRA Shared Consumable Capacity alpha feature: - Add DRASharedConsumableCapacity feature gate description - Add "Shared consumable capacity" section to the DRA concepts page with SR-IOV bandwidth example showing requestPolicy on shared counters and valueFrom mappings on device counter consumption Signed-off-by: Sebastian Sch <sebassch@gmail.com>
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
kubernetes-prow
Bot
added
the
cncf-cla: yes
kubernetes-prow
Bot
added
the
language/en
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
size/L
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/assign @kernel-kun |
|
Hi @SchSeba, @LionelJouin 👋! v1.37 Docs team here We noticed that this Pull Request is currently in the Open state. Note Could you please confirm:
Important Upcoming Docs Deadlines:
Please let us know so we can track this accurately on our end. Thanks! |
|
/wg device-management |
kubernetes-prow
Bot
added
the
wg/device-management
kubernetes-prow
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@SchSeba could you please rebase this? We need to review and have this merged today. :) |
nojnhuh
left a comment
nojnhuh
left a comment
There was a problem hiding this comment.
LGTM overall, just one suggestion about where to move this section and another for consistency with other recent changes.
| `DRAListTypeAttributes` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) | ||
| is enabled in the kube-apiserver and kube-scheduler. | ||
|
|
||
| ### Shared consumable capacity {#shared-consumable-capacity} |
There was a problem hiding this comment.
#56295 reorganized these docs into multiple pages. Right after the "Consumable Capacity" section seems like a reasonable place to move this section:
| Shared consumable capacity is an *alpha feature* and only enabled when the | ||
| [`DRASharedConsumableCapacity` feature gate](/docs/reference/command-line-tools-reference/feature-gates/#DRASharedConsumableCapacity) | ||
| is enabled in the kube-apiserver and kube-scheduler. |
There was a problem hiding this comment.
#56295 also tweaked how the feature gates for each feature are described:
| Shared consumable capacity is an *alpha feature* and only enabled when the | |
| [`DRASharedConsumableCapacity` feature gate](/docs/reference/command-line-tools-reference/feature-gates/#DRASharedConsumableCapacity) | |
| is enabled in the kube-apiserver and kube-scheduler. | |
| Shared consumable capacity is controlled by the | |
| [`DRASharedConsumableCapacity`](/docs/reference/command-line-tools-reference/feature-gates/#DRASharedConsumableCapacity) feature gate | |
| in the `kube-apiserver` and `kube-scheduler`. |
7 participants
Description
Add documentation for the DRA Shared Consumable Capacity alpha feature:
with SR-IOV bandwidth example showing requestPolicy on shared
counters and valueFrom mappings on device counter consumption