update network-policy by adding egress and ipBlock usage #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
Deploy preview ready! Built with commit 503f9ef https://deploy-preview-5473--kubernetes-io-master-staging.netlify.com |
|
/cc @cmluciano , I thought it might necessary to add some instructions of egress and ipBlock to network-policy docs, so I did it. Would you please to a quick look to see whether I wrote something wrong. Thanks! |
|
LGTM from a docs standpoint; waiting for review from @cmluciano to merge. 👍 |
|
@cmluciano 👋 Bumping for review. |
| @@ -62,6 +77,13 @@ __podSelector__: Each `NetworkPolicy` includes a `podSelector` which selects the | |||
|
|
|||
| __ingress__: Each `NetworkPolicy` includes a list of whitelist `ingress` rules. Each rule allows traffic which matches both the `from` and `ports` sections. The example policy contains a single rule, which matches traffic on a single port, from either of two sources, the first specified via a `namespaceSelector` and the second specified via a `podSelector`. | |||
|
|
|||
| __egress__: Each `NetworkPolicy` includes a list of whitelist `egress` rules. Each rule allows traffic which matches both the `ports` and `to` sections. The example policy contains a single rule, which matches traffic on a single port, to either of two sources, the first specified via a `namespaceSelector` and the second specified via a `podSelector`. | |||
|
|
|||
| __ipBlock__: `ipBlock` describes a particular CIDR that is allowed to | |||
There was a problem hiding this comment.
This is a bit asymmetrical - we don't document the podSelector and namespaceSelector bits here, which are equivalent.
Not sure if we care though?
k8s-ci-robot
added
size/XS
|
@cmluciano okay, that might be better, already changed, thanks |
This was referenced Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update network-policy by adding egress and ipBlock usage
This change is