Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove petset documentation #5395

Merged
merged 1 commit into from
Sep 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion _data/concepts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ toc:
- docs/concepts/workloads/controllers/replicationcontroller.md
- docs/concepts/workloads/controllers/deployment.md
- docs/concepts/workloads/controllers/statefulset.md
- docs/concepts/workloads/controllers/petset.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure a change to _data is needed or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should update when you build the documentations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for verifying that a change to _data is needed. :)

- docs/concepts/workloads/controllers/daemonset.md
- docs/concepts/workloads/controllers/garbage-collection.md
- docs/concepts/workloads/controllers/jobs-run-to-completion.md
Expand Down
12 changes: 7 additions & 5 deletions _redirects
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
/docs/api /docs/concepts/overview/kubernetes-api 301

/docs/concepts/abstractions/controllers/garbage-collection /docs/concepts/workloads/controllers/garbage-collection 301
/docs/concepts/abstractions/controllers/petsets /docs/concepts/workloads/controllers/petset 301
Copy link
Contributor Author

@crimsonfaith91 crimsonfaith91 Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on netlify website documentation, i think we should remove petset items from the redirects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. We don't want to remove any URLs from the left column of _redirects. We want to keep all the existing URLs in the left column, but change the target URL in the right column.

Also, for each topic that is being removed from the doc set, add the URL of the removed topic to the left column of _redirects, and put an appropriate target URL in the right column.

/docs/concepts/abstractions/controllers/petsets /docs/concepts/workloads/controllers/statefulset 301
/docs/concepts/abstractions/controllers/statefulsets /docs/concepts/workloads/controllers/statefulset 301
/docs/concepts/abstractions/init-containers /docs/concepts/workloads/pods/init-containers 301
/docs/concepts/abstractions/overview /docs/concepts/overview/working-with-objects/kubernetes-objects 301
Expand Down Expand Up @@ -193,10 +193,12 @@
/docs/user-guide/node-selection /docs/concepts/configuration/assign-pod-node 301
/docs/user-guide/persistent-volumes /docs/concepts/storage/persistent-volumes 301
/docs/user-guide/persistent-volumes/walkthrough /docs/tasks/configure-pod-container/configure-persistent-volume-storage 301
/docs/user-guide/petset /docs/concepts/workloads/controllers/petset 301
/docs/user-guide/petset/bootstrapping /docs/concepts/workloads/controllers/petset 301
/docs/user-guide/pod-preset /docs/tasks/inject-data-application/podpreset 301
/docs/user-guide/pod-security-policy /docs/concepts/policy/pod-security-policy 301
/docs/user-guide/petset /docs/concepts/workloads/controllers/statefulset 301
/docs/user-guide/petset/bootstrapping /docs/concepts/workloads/controllers/statefulset 301
/docs/abstractions/controllers/petset /docs/concepts/workloads/controllers/statefulset 301
/docs/concepts/workloads/controllers/petsets /docs/concepts/workloads/controllers/statefulset 301
/docs/user-guide/pod-preset/ /docs/tasks/inject-data-application/podpreset 301
/docs/user-guide/pod-security-policy/ /docs/concepts/policy/pod-security-policy 301
/docs/user-guide/pod-states /docs/concepts/workloads/pods/pod-lifecycle 301
/docs/user-guide/pod-templates /docs/concepts/workloads/pods/pod-overview 301
/docs/user-guide/pods /docs/concepts/workloads/pods/pod 301
Expand Down
51 changes: 0 additions & 51 deletions cn/docs/concepts/workloads/controllers/petset.yaml

This file was deleted.

Loading