Skip to content

Conversation

@rxinui
Copy link

@rxinui rxinui commented Sep 29, 2025

Description

As requested here by @lmktfy - this PR serves as a placeholder and aims to provide KYAML supports reference.

Issue

Linked to #52523 (review)

@netlify
Copy link

netlify bot commented Sep 29, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 0eced77
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/690ccaeec0f9120008c1df33

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2025
@netlify
Copy link

netlify bot commented Sep 29, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0eced77
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/690ccaee08b0350008b16019
😎 Deploy Preview https://deploy-preview-52583--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rxinui
Copy link
Author

rxinui commented Sep 29, 2025

cc: @lmktfy @soltysh

@lmktfy
Copy link
Member

lmktfy commented Sep 29, 2025

/retitle [WIP] KYAML reference placeholder

@k8s-ci-robot k8s-ci-robot changed the title Kyaml placeholder [WIP] KYAML reference placeholder Sep 29, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025
@lmktfy
Copy link
Member

lmktfy commented Sep 29, 2025

/milestone 1.35

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Sep 29, 2025
@soltysh soltysh mentioned this pull request Oct 1, 2025
15 tasks
@rxinui rxinui force-pushed the kyaml-placeholder branch from 20c76f6 to 647d12a Compare October 29, 2025 13:43
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2025
@rxinui
Copy link
Author

rxinui commented Oct 29, 2025

CC: @thockin

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

@soltysh
Copy link
Contributor

soltysh commented Oct 30, 2025

@rxinui is it still WIP, or this is ready for finalization?

@rxinui rxinui force-pushed the kyaml-placeholder branch from 5370f0d to a4520eb Compare October 30, 2025 11:23
@rxinui rxinui changed the title [WIP] KYAML reference placeholder KYAML reference placeholder Oct 30, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@rxinui
Copy link
Author

rxinui commented Oct 30, 2025

It is now ready @soltysh @lmktfy

No longer WIP.

@rxinui rxinui force-pushed the kyaml-placeholder branch 3 times, most recently from f8fbca0 to dd4b9ac Compare October 30, 2025 14:03
Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback

@rxinui rxinui force-pushed the kyaml-placeholder branch from 064785e to 6d5f559 Compare October 30, 2025 14:13
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2025
@lmktfy
Copy link
Member

lmktfy commented Oct 30, 2025

The required follow-on work includes checking each of the examples (either with a linter program, or manually) to make sure it really is idiomatic, pretty printed, valid KYAML.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2025
@rxinui
Copy link
Author

rxinui commented Oct 30, 2025

I'm happy to see it go in, so long as there's enough of a commitment from other contributors (or from you, @rxinui, if you'd like to do more work).

No problem, will be happy to continue and help!

The required follow-on work includes checking each of the examples (either with a linter program, or manually) to make sure it really is idiomatic, pretty printed, valid KYAML.

I have updated the examples to provide working examples. All KYAML manifests have been tested using kubectl apply to ensure kube-apiserver validates them.

@lmktfy
Copy link
Member

lmktfy commented Oct 30, 2025

I'm happy to see it go in, so long as there's enough of a commitment from other contributors (or from you, @rxinui, if you'd like to do more work).

No problem, will be happy to continue and help!

The required follow-on work includes checking each of the examples (either with a linter program, or manually) to make sure it really is idiomatic, pretty printed, valid KYAML.

I have updated the examples to provide working examples. All KYAML manifests have been tested using kubectl apply to ensure kube-apiserver validates them.

kubectl accepts any valid YAML. We need to check that they're KYAML. Have a look at the KEP to see what's actually required.

@lmktfy
Copy link
Member

lmktfy commented Oct 31, 2025

In kubernetes/enhancements#5295 (comment) @thockin mentioned yamlfmt.

The test I want to use is: are our examples of KYAML correct enough that people will look at them and not feel misled?

(a later PR might want to hint at KYAML as an output format, which as a user you can always consider "correct"; versus KYAML as something that you might want to recommend in code style guidelines etc)

If a tool like Helm rendered to KYAML, we don't and I think won't have a conformance test that Helm needs to pass. Except, of course, that the YAML does have to be valid YAML.

@lmktfy
Copy link
Member

lmktfy commented Oct 31, 2025

I am happy to give this another LGTM unless it has substantial changes since I approved it.

@soltysh
Copy link
Contributor

soltysh commented Nov 6, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 6, 2025
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits regarding the links, otherwise this lgtm from sig-cli pov

@rxinui rxinui force-pushed the kyaml-placeholder branch from 21d1816 to 0eced77 Compare November 6, 2025 16:20
@rxinui
Copy link
Author

rxinui commented Nov 6, 2025

@soltysh @lmktfy I have now applied all the fixes requested.

Please review or/and approve if everything is in order!

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rxinui I would like to merge this, but even as a stub, I think accepting it would not make the docs better. I am sorry that I need to cancel the LGTM on this PR but it just doesn't seem correct.

A stub reference page should not materially mislead readers, and this would. Someone looking for a KYAML reference who came across this page as drafted could well build a mental model of KYAML that ends up annoyingly wrong. The accuracy bar is high, I'm afraid (we are fine with incomplete, but we are going to insist on accurate).

You must, must read https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/5295-kyaml/README.md and make sure that you understand it enough to document the format.

If the KEP is wrong – which can happen – we need to point that out to reviewers. If the KEP is correct, what we document must materially match the KEP.

There are some places where the PR doesn't align with the documentation style guide, and I hope you'll fix those too, but if there were only some style issues, I would have approved the PR.

We can still fix it. I hope you will look at the KEP and at example KYAML outputs and at this draft document and work out which of those three is wrong. It does seem to me that at least one of them is.

/lgtm cancel
/retitle Add stub reference for KYAML

@k8s-ci-robot k8s-ci-robot changed the title KYAML reference placeholder Add stub reference for KYAML Nov 6, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@rxinui
Copy link
Author

rxinui commented Nov 6, 2025

You must, must read https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/5295-kyaml/README.md and make sure that you understand it enough to document the format.

@lmktfy give me more time to re-read and correct the kyaml example.

For my information, how would you approve whether or not the example given matches KYAML format (more than my current example?)

@lmktfy
Copy link
Member

lmktfy commented Nov 6, 2025

(I helped out a bit with the design of KYAML, so drawing on what I remember I can glance at an example and see if it looks right - but that probably won't help you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants