Skip to content

Add banner for KubeCon 2025 NA #52126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 7, 2025
Merged

Add banner for KubeCon 2025 NA #52126

merged 6 commits into from
Sep 7, 2025

Conversation

@bismayam
Copy link
Contributor

@bismayam bismayam commented Aug 31, 2025 •
edited
Loading

Description

Added banner for KubeCon 2025 NA

image

Issue

#52031

Closes: #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2025
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 31, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tengqm August 31, 2025 04:07
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2025
@netlify
Copy link

netlify bot commented Aug 31, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 72d963f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68ba6f53fdf35b0008f2b751
😎 Deploy Preview https://deploy-preview-52126--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bismayam bismayam marked this pull request as ready for review August 31, 2025 04:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2025
@bismayam bismayam mentioned this pull request Aug 31, 2025
Closed
Arhell
Arhell reviewed Sep 1, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pacoxu
Copy link
Member

pacoxu commented Sep 1, 2025

cc @kubernetes/steering-committee

soltysh
soltysh approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from steering

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 1, 2025

LGTM label has been added.

Git tree hash: 901d4c9b04a502f78f5178d7fb7b1d698bd08c0b

@soltysh
Copy link
Contributor

soltysh commented Sep 1, 2025

/hold
for steering ack

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2025
@pacoxu
Copy link
Member

pacoxu commented Sep 1, 2025

+1 （Steering）

@saschagrunert
Copy link
Member

saschagrunert commented Sep 1, 2025

+1 from steering

@pohly
Copy link
Contributor

pohly commented Sep 1, 2025 •
edited
Loading

+1 (Steering)

@aojea
Copy link
Member

aojea commented Sep 1, 2025

+1 (steering)

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Sep 1, 2025

/committee steering

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Sep 1, 2025
@soltysh
Copy link
Contributor

soltysh commented Sep 1, 2025

/hold cancel
we have sufficient acks from steering, you just need approval from website owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2025
Kavyanjana
Kavyanjana reviewed Sep 4, 2025
View reviewed changes
@BenTheElder
Copy link
Member

BenTheElder commented Sep 4, 2025

+1 Steering

A nit: Maybe we should disable the visited link color in favor of remaining white, for better contrast?

#52126 (comment) looks hard to read.

@nate-double-u
Copy link
Contributor

nate-double-u commented Sep 4, 2025 •
edited
Loading

A nit: Maybe we should disable the visited link color in favor of remaining white, for better contrast?

#52126 (comment) looks hard to read.

+1, agreed

@nate-double-u
Copy link
Contributor

nate-double-u commented Sep 4, 2025

There are a lot of unrelated formatting updates now. Let's only change the section that we need to change for this event, @bismayam.

@BenTheElder
Copy link
Member

BenTheElder commented Sep 5, 2025

There are a lot of unrelated formatting updates now. Let's only change the section that we need to change for this event, @bismayam.

Please, it obscures the git history unnecessarily and makes the review harder (we need to check that those changes are in fact only formatting ...)

@bismayam
Merge pull request #1 from Kavyanjana/patch-1
4697bea 
Update the banner colour to match the event scheme
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 5, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 5, 2025
@bismayam
Copy link
Contributor Author

bismayam commented Sep 5, 2025

image

@nate-double-u
The formatting was previously affected by the editor, but it has now been cleaned up with your suggested changes. Could you please take a look now.

@lmktfy
Copy link
Member

lmktfy commented Sep 7, 2025

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 7, 2025
@lmktfy
Copy link
Member

lmktfy commented Sep 7, 2025

Changes since Steering approval look trivial if we get a squash merge, so:
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 7, 2025

LGTM label has been added.

Git tree hash: 5f3b6a778b5b87671b890156e7c5fa8ce6a330c2

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2025
@lmktfy lmktfy dismissed nate-double-u’s stale review September 7, 2025 13:49

Approving this. We still have time to revise the banner before it goes live.

@lmktfy
Copy link
Member

lmktfy commented Sep 7, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 05a89cf into kubernetes:main Sep 7, 2025
6 checks passed
@nate-double-u
Copy link
Contributor

nate-double-u commented Sep 9, 2025

Thanks for putting this together @bismayam, and thanks for the quick review everyone!

@dipesh-rawat dipesh-rawat mentioned this pull request Oct 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm Awaiting requested review from tengqm

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@salaxander salaxander Awaiting requested review from salaxander

@soltysh soltysh Awaiting requested review from soltysh

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

2 more reviewers

@Arhell Arhell Arhell left review comments

@Kavyanjana Kavyanjana Kavyanjana left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@lmktfy lmktfy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.