-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Enhance PSI example CPU stress pod; fix PSI Prometheus metrics grep regex #52037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…egex Add CPU resource requests and limits to the example CPU stress pod to produce more reliable CPU stress. Fix PSI Prometheus metrics grep regex so that users can correctly query the metrics for the target containers.
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@roycaihw , with |
|
@reylejano Thanks. Changed to |
|
Based on slack communication (@aibarbetta), the PSI 1.34 blog is being scheduled to get published on Sep 4. Can we prioritize reviewing this PSI doc fix? I want to block the blog post on this doc fix. @lmktfy @haircommander @reylejano |
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. Git tree hash: e9be6e6cea5814a24e20cdd3cf730b826e7b88e6
|
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Followup of #51541
Some enhancement and fix to the "understanding PSI" doc:
Ref kubernetes/enhancements#4205
/cc @lmktfy @haircommander