Skip to content

Conversation

@roycaihw
Copy link
Member

Description

Followup of #51541

Some enhancement and fix to the "understanding PSI" doc:

  1. Add CPU resource requests and limits to the example CPU stress pod to produce more reliable CPU stress. This is a best practice that we're also adding to the k/k E2E test. Also see evidence of PSI results for pods without the limit v.s. with the limit. Users will observe more visible PSI data for the latter.
  2. Fix PSI Prometheus metrics grep regex so that users can correctly query the metrics for the target containers. This was an oversight in the doc. See evidence of the actual metrics format.

Ref kubernetes/enhancements#4205

/cc @lmktfy @haircommander

…egex

Add CPU resource requests and limits to the example CPU stress pod to produce more reliable CPU stress.
Fix PSI Prometheus metrics grep regex so that users can correctly query the metrics for the target containers.
@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Aug 26, 2025
@netlify
Copy link

netlify bot commented Aug 26, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 13b5035
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68ade64bd131c4000864be73

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2025
@netlify
Copy link

netlify bot commented Aug 26, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 13b5035
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68ade64bc9067a0008f0cf86
😎 Deploy Preview https://deploy-preview-52037--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@reylejano
Copy link
Member

@roycaihw , with dev-1.34 branch merged to main yesterday, can you change the target of this PR to main

@roycaihw roycaihw changed the base branch from dev-1.34 to main August 28, 2025 23:30
@roycaihw
Copy link
Member Author

@reylejano Thanks. Changed to main. PTAL :)

@roycaihw
Copy link
Member Author

roycaihw commented Sep 2, 2025

Based on slack communication (@aibarbetta), the PSI 1.34 blog is being scheduled to get published on Sep 4. Can we prioritize reviewing this PSI doc fix? I want to block the blog post on this doc fix. @lmktfy @haircommander @reylejano

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e9be6e6cea5814a24e20cdd3cf730b826e7b88e6

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 394afb2 into kubernetes:main Sep 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants