-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[KEP-5075] DRAConsumableCapacity documentation #51479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @sunya-ch! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
I think this should target the dev-1.34 branch.
Does that sound right?
OK to unhold once target branch is confirmed.
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates/DRAConsumableCapacity.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates/DRAConsumableCapacity.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates/DRAConsumableCapacity.md
Outdated
Show resolved
Hide resolved
|
@lmktfy Thank you so much for the review. I have rebased to dev-1.34 and committed your suggestions. |
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
|
Resolved conflict and updated example according to latest API review.
|
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
Outdated
Show resolved
Hide resolved
| selectors: | ||
| - cel: | ||
| expression: |- | ||
| device.allowMultipleAllocations == true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required, right? This would limit the chose of device to ONLY those with consumable capacity. Let's leave it out of the basic example. Then, after your example allocation, I would add the paragraph:
In this example, a multiply-allocatable device was chosen. However, any resource.example.com device with at least the requested 1G bandwidth could have met the requirement. If a non-multiply-allocatable device were chosen, the allocation would have resulted in the entire device. To force the use of a only multiply-allocatable devices, you can use the CEL criteria device.allowMultipleAllocations == true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnbelamaric Thank you so much for your review and suggestions.
I have applied your suggestions here: https://github.com/kubernetes/website/compare/daec5a57dc2854717d08c33b7b2ef78a0c3f6e7b..f183ec7b3c9c2692fda288435c1e279386398432.
|
Hello @sunya-ch 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you! |
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
johnbelamaric
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
/hold cancel |
|
@sunya-ch thanks for this work! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, natalisucks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
ah, i missed that John is good to go for tech reviews on DRA content, adding the other label as well so we get things in for Docs Freeze |
|
LGTM label has been added. Git tree hash: 1cb78d40ee918e4f19d519493bd65fab182454f1
|
Yeah, I was using "approve" here for tech review approval, even though it has no effect from a tooling viewpoint |
|
I apologize for the oversight — I just noticed a mistake in this document after the merge and would like to add the below change. How should I proceed? diff --git a/content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md b/content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
index f9af94c36a..9ed9bccf88 100644
--- a/content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
+++ b/content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
@@ -588,8 +588,7 @@ spec:
requests:
- name: req-0
exactly:
- - name:
- deviceClassName: resource.example.com
+ - deviceClassName: resource.example.com |
Send a follow-up PR if you have not already |
Description
Docs change for KEP-5075.
Issue
kubernetes/enhancements: kubernetes/enhancements#5075
kubernetes/kubernetes: kubernetes/kubernetes#132522