Skip to content

Conversation

@sunya-ch
Copy link
Contributor

@sunya-ch sunya-ch commented Jul 2, 2025

Description

Docs change for KEP-5075.

Issue

kubernetes/enhancements: kubernetes/enhancements#5075
kubernetes/kubernetes: kubernetes/kubernetes#132522

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @sunya-ch!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from natalisucks and pohly July 2, 2025 14:13
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 2, 2025
@netlify
Copy link

netlify bot commented Jul 2, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2f8244a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/689007652ec1c100081b6643
😎 Deploy Preview https://deploy-preview-51479--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I think this should target the dev-1.34 branch.
Does that sound right?

OK to unhold once target branch is confirmed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025
@sunya-ch sunya-ch changed the base branch from main to dev-1.34 July 2, 2025 23:05
@sunya-ch
Copy link
Contributor Author

sunya-ch commented Jul 2, 2025

@lmktfy Thank you so much for the review. I have rebased to dev-1.34 and committed your suggestions.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2025
@netlify
Copy link

netlify bot commented Jul 28, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2f8244a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68900765471f270008e2d33d

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2025
@sunya-ch
Copy link
Contributor Author

Resolved conflict and updated example according to latest API review.

  • sharingPolicy --> requestPolicy
  • capacityRequests.minimum --> capacity.requests
  • validRange.minimum --> validRange.min
  • validRange.chunkSize --> validRange.step
  • consumedCapacities --> consumedCapacity

selectors:
- cel:
expression: |-
device.allowMultipleAllocations == true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required, right? This would limit the chose of device to ONLY those with consumable capacity. Let's leave it out of the basic example. Then, after your example allocation, I would add the paragraph:

In this example, a multiply-allocatable device was chosen. However, any resource.example.com device with at least the requested 1G bandwidth could have met the requirement. If a non-multiply-allocatable device were chosen, the allocation would have resulted in the entire device. To force the use of a only multiply-allocatable devices, you can use the CEL criteria device.allowMultipleAllocations == true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michellengnx
Copy link
Contributor

Hello @sunya-ch 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@johnbelamaric
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2025
@natalisucks
Copy link
Contributor

@sunya-ch thanks for this work!
@johnbelamaric Only SIG Docs approvers have the ability to add the approve label on docs PRs – would you mind adding your LGTM?
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@natalisucks
Copy link
Contributor

ah, i missed that John is good to go for tech reviews on DRA content, adding the other label as well so we get things in for Docs Freeze
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1cb78d40ee918e4f19d519493bd65fab182454f1

@k8s-ci-robot k8s-ci-robot merged commit 59d333c into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Aug 6, 2025
@johnbelamaric
Copy link
Member

@johnbelamaric Only SIG Docs approvers have the ability to add the approve label on docs PRs – would you mind adding your LGTM?

Yeah, I was using "approve" here for tech review approval, even though it has no effect from a tooling viewpoint

@sunya-ch
Copy link
Contributor Author

sunya-ch commented Aug 8, 2025

@natalisucks @johnbelamaric

I apologize for the oversight — I just noticed a mistake in this document after the merge and would like to add the below change. How should I proceed?

diff --git a/content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md b/content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
index f9af94c36a..9ed9bccf88 100644
--- a/content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
+++ b/content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md
@@ -588,8 +588,7 @@ spec:
       requests:
       - name: req-0
         exactly:
-        - name:
-          deviceClassName: resource.example.com
+        - deviceClassName: resource.example.com

@johnbelamaric
Copy link
Member

I apologize for the oversight — I just noticed a mistake in this document after the merge and would like to add the below change. How should I proceed?

Send a follow-up PR if you have not already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants