Skip to content

Conversation

@Caesarsage
Copy link
Contributor

Description

Background

Netlify builds have been failing due to “likely secret” detections in example Kubernetes Secret YAML blocks across multiple language docs. These are not real secrets, but their format triggers automated scanning.

What’s Changed

  • Replaced all example base64-encoded certificate and key values in affected files (English, Indonesian, Japanese, Korean, Chinese) with clear placeholders:
  data:
    # NOTE: Replace the following values with your own base64-encoded certificate and key.
    tls.crt: "REPLACE_WITH_BASE64_CERT"
    tls.key: "REPLACE_WITH_BASE64_KEY"

(Comment translated for each language.)

Why One PR for All Languages?

Normally, we submit one language per PR. However, since this issue affects all languages in the same way and blocks Netlify builds globally, fixing all at once is more efficient and ensures the site is unblocked for everyone. The change is mechanical and identical in intent.

Why Not Change Netlify Config?

Redacting the example values is more robust and improves clarity for users, making it clear these are placeholders.

Closes: #51395

…and key to fix nelify build failure

Replaced existing base64-encoded certificate and key values in multiple language examples with placeholders ("REPLACE_WITH_BASE64_CERT" and "REPLACE_WITH_BASE64_KEY") to guide users in providing their own values. This change enhances clarity and usability across the documentation.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language labels Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/hi Issues or PRs related to Hindi language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 26, 2025
@netlify
Copy link

netlify bot commented Jun 26, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit db2b186
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68626d8aaafe7400089052bb
😎 Deploy Preview https://deploy-preview-51398--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2025
@tengqm
Copy link
Contributor

tengqm commented Jun 27, 2025

please split this into PRs for each and every affected languages.

@Caesarsage
Copy link
Contributor Author

Caesarsage commented Jun 27, 2025

please split this into PRs for each and every affected languages.

@lmktfy suggested fixing all with 1 PR exception (as described on the description) from sig-docs slack channel as it's blocking Netlify build across.

But there is currently an on going discussions on the Issue to do some settings configuration from the Netlify directly to fix the false positive issue there.

Issue #51395

@lmktfy
Copy link
Member

lmktfy commented Jun 27, 2025

Why One PR for All Languages?

Normally, we submit one language per PR. However, since this issue affects all languages in the same way and blocks Netlify builds globally, fixing all at once is more efficient and ensures the site is unblocked for everyone. The change is mechanical and identical in intent.

Thanks for explaining this clearly. Sorry to hear you had complaints despite doing that.

@lmktfy
Copy link
Member

lmktfy commented Jun 27, 2025

Cancelling the hold from #51398 (review)

This PR proposes making an exception to our normal policy, and explains why. I agree with the exception (which I also proposed). Of course, we can put back that hold if we don't agree with the idea of the exception.

@lmktfy
Copy link
Member

lmktfy commented Jun 27, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2025
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM
I agree with merging this PR as an exception (without separating by language) because the fact that the build is failing across the entire website is more concerning

nit (does not block this PR): please insert exactly one newline at the end of each file

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@SayakMukhopadhyay
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48ce8847cb81d4aeeb97d7818d3daf9007bbfd7b

@k8s-ci-robot k8s-ci-robot merged commit 5dc80ac into kubernetes:main Jun 30, 2025
6 checks passed
asem-hamid pushed a commit to asem-hamid/website that referenced this pull request Aug 22, 2025
…rets

Redact Example Base64 Secrets in All Languages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language language/en Issues or PRs related to English language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Netlify PR build preview failing due to suspected secret in Service tutorial pages

7 participants