-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Redact Example Base64 Secrets in All Languages #51398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact Example Base64 Secrets in All Languages #51398
Conversation
…and key to fix nelify build failure
Replaced existing base64-encoded certificate and key values in multiple language examples with placeholders ("REPLACE_WITH_BASE64_CERT" and "REPLACE_WITH_BASE64_KEY") to guide users in providing their own values. This change enhances clarity and usability across the documentation.
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Arhell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#51364 (review)
/hold
|
please split this into PRs for each and every affected languages. |
@lmktfy suggested fixing all with 1 PR exception (as described on the description) from sig-docs slack channel as it's blocking Netlify build across. But there is currently an on going discussions on the Issue to do some settings configuration from the Netlify directly to fix the false positive issue there. Issue #51395 |
Thanks for explaining this clearly. Sorry to hear you had complaints despite doing that. |
|
Cancelling the hold from #51398 (review) This PR proposes making an exception to our normal policy, and explains why. I agree with the exception (which I also proposed). Of course, we can put back that hold if we don't agree with the idea of the exception. |
|
/hold cancel |
Okabe-Junya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM
I agree with merging this PR as an exception (without separating by language) because the fact that the build is failing across the entire website is more concerning
nit (does not block this PR): please insert exactly one newline at the end of each file
content/ko/docs/tutorials/services/connect-applications-service.md
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…tions to improve clarity
|
/lgtm |
|
LGTM label has been added. Git tree hash: 48ce8847cb81d4aeeb97d7818d3daf9007bbfd7b
|
…rets Redact Example Base64 Secrets in All Languages
Description
Background
Netlify builds have been failing due to “likely secret” detections in example Kubernetes Secret YAML blocks across multiple language docs. These are not real secrets, but their format triggers automated scanning.
What’s Changed
(Comment translated for each language.)
Why One PR for All Languages?
Normally, we submit one language per PR. However, since this issue affects all languages in the same way and blocks Netlify builds globally, fixing all at once is more efficient and ensures the site is unblocked for everyone. The change is mechanical and identical in intent.
Why Not Change Netlify Config?
Redacting the example values is more robust and improves clarity for users, making it clear these are placeholders.
Closes: #51395