Kubeadm upgrade phase navigation #51362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
Thanks for this fix! Works as expected now. The deployed preview page is here. /area web-development |
k8s-ci-robot
added
area/web-development
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 1f4c26a52a8f4568c6857ac1bef7d6491d9d73e0
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ajaysundark
pushed a commit
to ajaysundark/website
that referenced
this pull request
Jun 29, 2025
* chore: removing whitespaces * chore: clean up whitespace in training.css * Fix tab name collision in kubeadm upgrade phase documentation
rata
pushed a commit
to rata/kubernetes.github.io
that referenced
this pull request
Jul 1, 2025
* chore: removing whitespaces * chore: clean up whitespace in training.css * Fix tab name collision in kubeadm upgrade phase documentation
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "kubeadm upgrade node phase" section tabs were not updating content when clicked due to a name collision with the "kubeadm upgrade apply phase" section. Both tab groups were using the same name attribute, causing unexpected behavior.
Changes:
Changed the tab name for the "kubeadm upgrade node phase" section from name="tab-upgrade-phase" to name="tab-node-phase" to ensure unique tab group identifiers
This ensures each tab group has a unique name and prevents state sharing between different tab sections
Issue
Closes: #51358