Skip to content

Conversation

@lmktfy
Copy link
Member

@lmktfy lmktfy commented May 26, 2025

Small focused update to https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/

  • Don't assume that solution developers can reconfigure the cluster (recommend changing controller manager configuration, but treat this as secondary)
  • Consider a startup probe

/language en
/sig autoscaling

- Don't assume that solution developers can reconfigure the cluster
- Consider a startup probe
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels May 26, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2025
@netlify
Copy link

netlify bot commented May 26, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cfb8459
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68348a7b4979f800086cc13b
😎 Deploy Preview https://deploy-preview-51077--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from docs!

@divya-mohan0209
Copy link
Contributor

@kubernetes/sig-scheduling-leads : PTAL for a technical review

@macsko
Copy link
Member

macsko commented Jun 16, 2025

@divya-mohan0209 It looks like a non-scheduling related change. Maybe @kubernetes/sig-autoscaling-leads could help?

@towca
Copy link
Contributor

towca commented Jun 16, 2025

@adrianmoisey could you take a look?

@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 67a8580cad3f954b8541ba3b2c0d26c588e6b151

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit a2145d1 into kubernetes:main Jun 26, 2025
6 checks passed
@lmktfy lmktfy deleted the 20250526_tweak_hpa_good_practise branch September 20, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants