Footer not fixed anymore #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the footer not fixed anymore. The footer is very high, especially on laptops.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Signed it ;) |
|
CLAs look good, thanks! |
|
On page's like http://kubernetes.github.io/docs/getting-started-guides/docker-multinode/ the footer also overlaps the last paragraph(s) |
|
I'm sorry to have wasted your time but I just beat you to the punch! Thanks so much for the PR; don't be too discouraged -- I love seeing contributions. |
xingzhou
pushed a commit
to xingzhou/official.kubernetes.github.io
that referenced
this pull request
Aug 31, 2017
translate to chinese and now submit for review.
claudiajkang
added a commit
to claudiajkang/website2
that referenced
this pull request
Oct 3, 2018
* Initial translation of documentation home (kubernetes#9) * 번역할 원본 파일 추가 (kubernetes#11) * Translate tutorials/kubernetes-basics/create-cluster (kubernetes#15) * Translate tutorials/kubernetes-basics/deploy-app in Korean (kubernetes#16) * Translate tutorials/kubernetes-basics/expose in Korean (kubernetes#26) * Translate tutorials/kubernetes-basics/scale in Korean (kubernetes#24) * Fix typo from 세트 to 셋 according to 외래어 표기법 3.1.1 (kubernetes#31) * Setup page's header and subheader translate into Korean. (kubernetes#33) * Translated the welcome page in Korean (kubernetes#32) * Translate tutorials/kubernetes-basics/update in Korean (kubernetes#35) * Translate concepts/_index.md in Korean (kubernetes#30) * Translate tutorials/kubernetes-basics/index.html in Korean (kubernetes#29) * Translate /tutorials/hello-minikube.md in Korean (kubernetes#18) * Translate tutorials/kubernetes-basics/explore in Korean (kubernetes#36) * up-to-date on content/ko (kubernetes#42) * up-to-date on _index.html (kubernetes#41) * Translate tutorials/_index.md in Korean (kubernetes#44) * Update translation on tutorials/hello-minikube.md (kubernetes#45) * Setup page's header and subheader translate into Korean. (kubernetes#51) * Update tutorials for consistency (kubernetes#48) * up-to-date on content/ko (kubernetes#53) Co-authored-by: June Yi <[email protected]> Co-authored-by: Claudia J.Kang <[email protected]> Co-authored-by: zerobig <[email protected]> Co-authored-by: Lawlait <[email protected]> Co-authored-by: Ian Y. Choi <[email protected]>
claudiajkang
added a commit
to claudiajkang/website2
that referenced
this pull request
Oct 3, 2018
* Initial translation of documentation home (kubernetes#9) * 번역할 원본 파일 추가 (kubernetes#11) * Translate tutorials/kubernetes-basics/create-cluster (kubernetes#15) * Translate tutorials/kubernetes-basics/deploy-app in Korean (kubernetes#16) * Translate tutorials/kubernetes-basics/expose in Korean (kubernetes#26) * Translate tutorials/kubernetes-basics/scale in Korean (kubernetes#24) * Fix typo from 세트 to 셋 according to 외래어 표기법 3.1.1 (kubernetes#31) * Setup page's header and subheader translate into Korean. (kubernetes#33) * Translated the welcome page in Korean (kubernetes#32) * Translate tutorials/kubernetes-basics/update in Korean (kubernetes#35) * Translate concepts/_index.md in Korean (kubernetes#30) * Translate tutorials/kubernetes-basics/index.html in Korean (kubernetes#29) * Translate /tutorials/hello-minikube.md in Korean (kubernetes#18) * Translate tutorials/kubernetes-basics/explore in Korean (kubernetes#36) * up-to-date on content/ko (kubernetes#42) * up-to-date on _index.html (kubernetes#41) * Translate tutorials/_index.md in Korean (kubernetes#44) * Update translation on tutorials/hello-minikube.md (kubernetes#45) * Setup page's header and subheader translate into Korean. (kubernetes#51) * Update tutorials for consistency (kubernetes#48) * up-to-date on content/ko (kubernetes#53) Co-authored-by: June Yi <[email protected]> Co-authored-by: Claudia J.Kang <[email protected]> Co-authored-by: zerobig <[email protected]> Co-authored-by: Lawlait <[email protected]> Co-authored-by: Ian Y. Choi <[email protected]>
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Feb 24, 2021
Signed-off-by: Kevin Lingerfelt <[email protected]>
Okabe-Junya
pushed a commit
to Okabe-Junya/website
that referenced
this pull request
Dec 4, 2023
* Fixing file names and adding @CathPag's how-to. * typo Co-authored-by: Mike Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the footer not fixed anymore. The footer is very high, especially on laptops.