Skip to content

4742 Expose Node Labels in Downward API Docs #49928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

4742 Expose Node Labels in Downward API Docs #49928

merged 1 commit into from
Apr 8, 2025

Conversation

@dshebib
Copy link
Contributor

@dshebib dshebib commented Feb 27, 2025

Description

Add documentation for KEP 4742
KEP: kubernetes/enhancements#4742
K/K: kubernetes/kubernetes#127092

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2025
@netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 207c914
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67f2f4fba3f15a00086c4a54

@dshebib dshebib mentioned this pull request Feb 27, 2025
Open
12 tasks
@netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 207c914
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f2f4fb8353120008d8ad3e
😎 Deploy Preview https://deploy-preview-49928--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dshebib dshebib force-pushed the 4742-node-labels-downward-api branch from 0d14bb3 to ac1d310 Compare March 21, 2025 01:25
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2025
dshebib
dshebib commented Mar 21, 2025
View reviewed changes
Copy link
Contributor Author

@dshebib dshebib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any appetite for a walkthrough demonstrating this feature?

@michellengnx
Copy link
Contributor

Hello @dshebib 👋

Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

@dshebib dshebib force-pushed the 4742-node-labels-downward-api branch from ac1d310 to d6d2b9d Compare March 25, 2025 04:21
@dshebib dshebib marked this pull request as ready for review March 25, 2025 04:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@rayandas
Copy link
Member

rayandas commented Apr 4, 2025

Hello @dshebib 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.
The status of this enhancement is marked as At risk for docs freeze. Thank you!

@dshebib dshebib force-pushed the 4742-node-labels-downward-api branch from d6d2b9d to 207c914 Compare April 6, 2025 21:41
@dshebib
Copy link
Contributor Author

dshebib commented Apr 6, 2025

/cc @andrewsykim @docandrew

@k8s-ci-robot k8s-ci-robot requested a review from andrewsykim April 6, 2025 21:41
@k8s-ci-robot
Copy link
Contributor

@dshebib: GitHub didn't allow me to request PR reviews from the following users: docandrew.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @andrewsykim @docandrew

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tengqm
Copy link
Contributor

tengqm commented Apr 6, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2025
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6942dbd1267700960888190de9154ccbad27a76

@k8s-ci-robot k8s-ci-robot merged commit ccd2edd into kubernetes:dev-1.33 Apr 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@Princesso Princesso Awaiting requested review from Princesso

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@thockin thockin Awaiting requested review from thockin

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dshebib @michellengnx @rayandas @k8s-ci-robot @tengqm @haircommander