Docs update as we promote JobBackoffLimitPerIndex to stable #49811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/M
12 tasks
mimowo
changed the title
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/sig apps |
k8s-ci-robot
added
the
sig/apps
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e8782919b6b4568d0fe183a038c85a086eebed27
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/assign @tengqm |
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/L
cortespao
reviewed
Mar 25, 2025
mimowo
force-pushed
the
backoffperindex-stable
branch
2 times, most recently
from
a9d01d2 to
6c8dbfd
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c423d89bc5e1c94b60f1ce05c361466f6903b7c6
|
sftim
reviewed
Mar 26, 2025
There was a problem hiding this comment.
The main thing I recommend is not deleting the existing feature-gate shortcode. Other feedback is less important to cover.
content/en/examples/controllers/job-backoff-limit-per-index-failindex.yaml
Outdated
Show resolved
Hide resolved
content/en/examples/controllers/job-backoff-limit-per-index-failindex.yaml
Show resolved
Hide resolved
content/en/examples/controllers/job-backoff-limit-per-index-failindex.yaml
Outdated
Show resolved
Hide resolved
k8s-ci-robot
removed
the
lgtm
Co-authored-by: Qiming Teng <[email protected]> Co-authored-by: Tim Bannister <[email protected]>
mimowo
force-pushed
the
backoffperindex-stable
branch
from
bf31eba to
1d19fe2
Compare
sftim
reviewed
Mar 27, 2025
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 39d4517e81a7e8b953d0f92d7901c856b47836f2
|
Co-authored-by: Tim Bannister <[email protected]>
k8s-ci-robot
removed
the
lgtm
|
@soltysh @cortespao @sftim thank you for reviewing. I believe all comments are addressed. PTAL. |
|
Tech LGTM in #49811 (review) /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4b4d4b5f3cebc418504e583aebc6ea6b4765d986
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
deepakkinni
pushed a commit
to deepakkinni/website
that referenced
this pull request
Apr 8, 2025
…es#49811) * Update docs as JobBackoffLimitPerIndex graduates to stable * Add an example for PodFailurePolicy with FailIndex * Review remarks Co-authored-by: Qiming Teng <[email protected]> Co-authored-by: Tim Bannister <[email protected]> * Review remark - new section and aligning the sections * Update content/en/docs/tasks/job/pod-failure-policy.md Co-authored-by: Tim Bannister <[email protected]> --------- Co-authored-by: Qiming Teng <[email protected]> Co-authored-by: Tim Bannister <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the documentation as we are promoting JobBackoffLimitPerIndex to stable in 1.33.
The code changes are already merged in PR: kubernetes/kubernetes#130061
Also proposing to extend the documentation of the tasks page for handling BackoffLimitPerIndex, as proposed in the KEP's graduation criteria: "Revisit extending the hands-on guide for Pod failure policy to use FailIndex".
Issue
Enhancement-tracking issue: kubernetes/enhancements#3850