Fix duplicated glossary entry for CRI #48794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: cb6eabe4ba0a88facb2149608043d01f2b8d5253
|
k8s-ci-robot
removed
the
lgtm
Signed-off-by: Dmitry Shurupov <[email protected]> Co-authored-by: Tim Bannister <[email protected]>
shurup
force-pushed
the
glossary-rm-duplicated-cri
branch
from
b87f7ec to
23b3e52
Compare
|
Thanks, @sftim! I applied your suggestion and squashed it. A new |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d5f1c25b6272f03f6664b3677152d727dfa5c0ea
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have two conflicting glossary entries for CRI:
content/en/docs/reference/glossary/cri.md(added in 2019 via Add CRI to glossary #13024)content/en/docs/reference/glossary/container-runtime-interface.md(added in 2021 via Add CRI architecture to cluster concepts #30606)If you open the actual glossary, the first one will be displayed only under the name "Container runtime interface (CRI)".
This PR:
cri.mdin favour ofcontainer-runtime-interface.md(since the latter was added/reviewed more recently);container-runtime-interface.mdfile tocri.md(because this is how it's currently done forcniandcsi);cri.md: itsterm_idbecomescri, its title becomesContainer Runtime Interface (CRI)(includes the abbreviation), itstagschanged fromcritofundamental(that's how it was for the currently displayed CRI entry);<glossary_tooltip term_id="container-runtime-interface"...>entries to the newterm_id(i.e.cri).