Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention graceful_node_shutdown_state in kubelet local files page #48747

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Nov 18, 2024

Description

Add a mention of the file graceful_node_shutdown_state on the page https://kubernetes.io/docs/reference/node/kubelet-files/

Issue

Closes: #48610

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chanieljdan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Nov 18, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1342e98
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673aa672d5a40d0008e5d112
😎 Deploy Preview https://deploy-preview-48747--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 705d9175e5bcbe2eacacbebc00aed59c0228fa11

@reylejano
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 21, 2024
Comment on lines +148 to +149
[Graceful node shutdown](docs/concepts/cluster-administration/node-shutdown/#graceful-node-shutdown)
local storage state is located at `/var/lib/kubelet/graceful_node_shutdown_state`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Suggested change
[Graceful node shutdown](docs/concepts/cluster-administration/node-shutdown/#graceful-node-shutdown)
local storage state is located at `/var/lib/kubelet/graceful_node_shutdown_state`.
[Graceful node shutdown](docs/concepts/cluster-administration/node-shutdown/#graceful-node-shutdown)
stores state locally at `/var/lib/kubelet/graceful_node_shutdown_state`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Development

Successfully merging this pull request may close these issues.

Mention graceful_node_shutdown_state in kubelet local files page
4 participants