Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release announcement for v1.32 #48666

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

mbianchidev
Copy link
Member

@mbianchidev mbianchidev commented Nov 8, 2024

PR for adding the Kubernetes 1.32 release blog.

Mergeable before Kubernetes v1.32 is released since this PR contains a draft: true attribute in the file metadata.

This blog includes the majority of the identified Major themes from this discussion: kubernetes/sig-release#2639

In subsitution to the usual blog merge process it will be necessary to open a second PR to remove the draft: true attribute on the day of the release, this PR will also include the release name, the logo, the story behind the logo and the definitive date for the release webinar (chapters containing this info are marked in the title as WIP) - see this discussion.

EDIT (post-merge): Opened a follow-up PR to incorporate more feedback from the SIGs
#48955

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Nov 8, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2024
@mbianchidev
Copy link
Member Author

mbianchidev commented Nov 8, 2024

Holding until release 1.32 has happened - in addition to the usual process it will be necessary for a maintainer (sig-docs-blog) to remove the draft: true attribute - see this discussion.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
Copy link

netlify bot commented Nov 8, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a325694
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67503847ba2f010008d82b92
😎 Deploy Preview https://deploy-preview-48666--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Nov 8, 2024

In subsitution to the usual process it will be necessary for a maintainer (sig-docs-blog) to remove the draft: true attribute once the release has happened - see this discussion.

We can have that PR ready to go (already approved, ready to unhold) ahead of the release, so that SIG Docs blog team aren't needed on release day itself.

or
the release docs team can do that approval

@mbianchidev
Copy link
Member Author

In subsitution to the usual process it will be necessary for a maintainer (sig-docs-blog) to remove the draft: true attribute once the release has happened - see this discussion.

We can have that PR ready to go (already approved, ready to unhold) ahead of the release, so that SIG Docs blog team aren't needed on release day itself.

or the release docs team can do that approval

Actually we could merge this one no problem (draft: true) whenever we get a full tech + content review.
Then I could open a second PR on the day, just to remove such attribute and add the release topic and image which are under embargo, as they shouldn't require any additional review.

In this case we still don't need sig-docs people on the day and we can just operate within the release team for the second PR.

WDYT?

@sftim
Copy link
Contributor

sftim commented Nov 11, 2024

Then I could open a second PR on the day, just to remove such attribute and add the release topic and image which are under embargo, as they shouldn't require any additional review.

Almost. Don't open the second PR on the day; open it earlier and get the release-day steps agreed (we can make a written record that we're happy to see changes made on release day, that kind of thing). Then update the second PR once ready to.

@mbianchidev
Copy link
Member Author

Then I could open a second PR on the day, just to remove such attribute and add the release topic and image which are under embargo, as they shouldn't require any additional review.

Almost. Don't open the second PR on the day; open it earlier and get the release-day steps agreed (we can make a written record that we're happy to see changes made on release day, that kind of thing). Then update the second PR once ready to.

Makes sense, I will open it earlier but update it on the day with the logo plus the lore behind it.
It will just contain that and a removal of draft: true.

@mbianchidev mbianchidev changed the title WIP: Draft v1.32 release blog Draft v1.32 release blog Nov 23, 2024
@mbianchidev mbianchidev marked this pull request as ready for review November 23, 2024 13:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim November 23, 2024 13:32
@sftim
Copy link
Contributor

sftim commented Nov 23, 2024

🛑 Mergeable before Kubernetes v1.32 is released since this PR contains a draft: true attribute in the file metadata 🛑

Maybe take the stop symbols out of that line @mbianchidev 😉

@mbianchidev mbianchidev changed the title Draft v1.32 release blog Release blog v1.32 - content Nov 24, 2024
@sftim
Copy link
Contributor

sftim commented Nov 26, 2024

I recommend rebasing on main once #48858 has merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7783dc2136fa64898c9d050547308e81484ddc8

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim December 3, 2024 10:45
@sftim
Copy link
Contributor

sftim commented Dec 3, 2024

/approve cancel

Needs a new review

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@haircommander
Copy link
Contributor

LGTM from SIG node perspective

@sftim
Copy link
Contributor

sftim commented Dec 5, 2024

As a draft:
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d2c1bf7606af0745933cc264c0aaa5a511869fd2

@sftim
Copy link
Contributor

sftim commented Dec 5, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 45b99a3 into kubernetes:main Dec 5, 2024
6 checks passed
@mbianchidev
Copy link
Member Author

Opened a follow-up PR to fix a missing highlight from SIG Network and to incorporate eventual additional feedback from the SIGs

#48955

Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing a review from SIG-Scheduling.
I left one minor fix, others LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.