Skip to content

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Oct 24, 2024

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2024
@netlify
Copy link

netlify bot commented Oct 24, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 73070d8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6744daf4a7cf080008c36797
😎 Deploy Preview https://deploy-preview-48532--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please read https://kubernetes.io/docs/contribute/new-content/new-features/#ready-for-review-feature-gates to learn about the extra changes you are likely to need to make.

/hold
This change should target the dev-1.32 branch; main is the live website.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@gnufied gnufied changed the base branch from main to dev-1.32 October 24, 2024 19:48
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 24, 2024
@netlify
Copy link

netlify bot commented Oct 24, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 73070d8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6744daf4f736e20007a5028c

@gnufied gnufied changed the title Mark RecoverVolumeExpansionFailure as beta {Draft} Mark RecoverVolumeExpansionFailure as beta Oct 24, 2024
@gnufied gnufied changed the title {Draft} Mark RecoverVolumeExpansionFailure as beta Mark RecoverVolumeExpansionFailure as beta Nov 18, 2024
@tengqm
Copy link
Contributor

tengqm commented Nov 19, 2024

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnufied The PR is currently lacking the change to transition the feature gate RecoverVolumeExpansionFailure from Alpha to Beta. The necessary change should be made in the feature gate description file -
recover-volume-expansion-failure.md (here).

Please refer to the documentation here for further information.

@rdalbuquerque
Copy link
Contributor

Hello @gnufied 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday November 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2024
@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b1dcfb5a746a8085a5b54c371da36cf3c5409c1c

@k8s-ci-robot k8s-ci-robot merged commit 0c759e1 into kubernetes:dev-1.32 Nov 25, 2024
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants