-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Mark RecoverVolumeExpansionFailure as beta #48532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Please read https://kubernetes.io/docs/contribute/new-content/new-features/#ready-for-review-feature-gates to learn about the extra changes you are likely to need to make.
/hold
This change should target the dev-1.32 branch; main is the live website.
5b40fd6 to
51e5fea
Compare
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
Co-authored-by: Tim Bannister <[email protected]>
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnufied The PR is currently lacking the change to transition the feature gate RecoverVolumeExpansionFailure from Alpha to Beta. The necessary change should be made in the feature gate description file -
recover-volume-expansion-failure.md (here).
Please refer to the documentation here for further information.
|
Hello @gnufied 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday November 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you! |
|
/lgtm |
|
LGTM label has been added. Git tree hash: b1dcfb5a746a8085a5b54c371da36cf3c5409c1c
|
xref kubernetes/enhancements#1790