Skip to content

Conversation

@jsafrane
Copy link
Member

@jsafrane jsafrane commented Oct 23, 2024

Description

This is documentation of SELinuxMount and SELinuxChangePolicy features for 1.32.

KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1710-selinux-relabeling

It is a complex feature. There are three feature gates + a new controller that affect SELinux + possible breaking change. I tried to put everything into "Assign SELinux labels to a Container" chapter.
It will get much simpler when all feature gates graduate to GA.

In the future Kubernetes releases, the feature gates will be get enabled in the sequence describe in the kep, requiring cluster admins to check their cluster before upgrades and opt-out when necessary. I think that will need to be documented in the release when the features are enabled by default and not now.

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2024
@netlify
Copy link

netlify bot commented Oct 23, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 8e17234
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/673c54742e20d90008b20024

@netlify
Copy link

netlify bot commented Oct 23, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8e17234
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673c547432ef4f00083ce9b6
😎 Deploy Preview https://deploy-preview-48515--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rdalbuquerque
Copy link
Contributor

Hello @jsafrane 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday November 19th 2024 18:00 PST. Thank you!

@rdalbuquerque
Copy link
Contributor

Hi @jsafrane , just a friendly reminder to get you PR ready for review before Tuesday November 19th, thanks!

@jsafrane jsafrane marked this pull request as ready for review November 18, 2024 12:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@tengqm
Copy link
Contributor

tengqm commented Nov 19, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8b8f36bada753bfb64ddbc0d805d4b2ba39e18e

@rdalbuquerque
Copy link
Contributor

Hi @nate-double-u,
Docs Shadow here!
As we approach the docs freeze on November 26th, could you please take a look at this PR when you have a chance?

Thank you so much!

Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Otherwise it looks good to me.

with different SELinux labels:
1. It emits an event to both of the Pods. `kubectl describe pod <pod-name>` the shows
`SELinuxLabel "<label on the pod>" conflicts with pod <the other pod name> that uses the same volume as this pod
with SELinuxLabel "<the other pod label>". If both pods land on the same node, only one of them may access the volume`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: volume` -> volume

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that is the text from the event copied verbatim and there is indeed a trailing ``` to close the markdown inline section.


When enabled, the controller observes running Pods and when it detects that two Pods use the same volume
with different SELinux labels:
1. It emits an event to both of the Pods. `kubectl describe pod <pod-name>` the shows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "the shows" -> "that shows"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@xing-yang
Copy link
Contributor

/assign @gnufied

@xing-yang
Copy link
Contributor

/lgtm

@chanieljdan
Copy link
Contributor

Tech LGTM and Docs LGTM are in place above

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chanieljdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 45b62d8 into kubernetes:dev-1.32 Nov 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants